1938223 - Extend (quietly) GIFFT to support labeled_counter -> keyed count and -> categorical histogram mirroring

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P2)

Description

[Chris H-C :chutten]

There are 16 (2 of which are TELEMETRY_TEST_*) kind: count, keyed: true histograms according to $ cat toolkit/components/telemetry/Histograms.json | jq 'to_entries | .[] | {key: .key, kind: .value.kind, keyed: .value.keyed} | select(.kind == "count") | select(.keyed) | .key'

(please do not judge my neophyte jq use too harshly. I'm learning)

The direct way to collect this shape of information in Glean would be by labeled_counter. Right now we support keyed scalar and hgram of kind: boolean. We need to add in support for hgrams of kind: count and keyed: true.

Comment 1

[Chris H-C :chutten]

Turns out the mapping to histograms with kind: categorical is straightforward to add while I'm in the neighbourhood.

Comment 2

[Chris H-C :chutten]

Attachment: Bug 1938223 - Support mirroring specific labeled_counter metrics to histograms of kind: categorical and keyed histograms of kind: count r?TravisLong

These are secret menu items. To use them:

• Metric of type: labeled_counter
• telemetry_mirror must have h# prefix before the histogram
• For categorical:
  • Samples must always be 1, or we'll assert
  • Labels must be specified in both probes with the same spelling, case, and
    order

Tests have been added to t/c/t/tests/python/test_mirrors.py to ensure these
restrictions are adhered to.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed191e0ecbd0
Support mirroring specific labeled_counter metrics to histograms of kind: categorical and keyed histograms of kind: count r=TravisLong

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/ed191e0ecbd0