1935420 - Migrate histograms to Glean - part 1 landing in Firefox 136

Status: RESOLVED FIXED

(Toolkit :: Telemetry, task)

Description

[Florian Quèze [:florian]]

Let's get started on migrating legacy telemetry histograms to Glean APIs using GIFFT to mirror the data back to legacy telemetry.

Comment 1

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - Migrate histograms to use Glean APIs in toolkit/components/reputationservice, r=chutten.

Comment 2

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - Migrate histograms to use Glean APIs in toolkit/components/reputationservice - migrate APPLICATION_REPUTATION_REASON by hand, r=chutten.

Comment 3

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - Migrate histograms to use Glean APIs for CONTENT_PROCESS_*, r=chutten.

Comment 4

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - Remove legacy histograms for GEOLOCATION_*, r=chutten.

Comment 5

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - Migrate histograms to use Glean APIs for MEMORY_PHC_*, r=chutten.

Comment 6

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - Migrate histograms to use Glean APIs in nsCycleCollector.cpp, r=chutten.

Comment 7

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - Migrate histograms to use Glean APIs in CycleCollectorStats.cpp, r=chutten.

Comment 8

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - Migrate histograms to use Glean APIs for remaining cycle collector histograms, r=chutten.

Comment 9

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - Migrate histograms to use Glean APIs for fontlist, r=chutten.

Comment 10

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - Migrate histograms to use Glean APIs in dom/crypto, r=chutten.

Comment 11

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - rewrite JS code storing histograms in local variables to make automatic glean migration easier, r=chutten.

Comment 12

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - rewrite more JS code storing histograms in local variables (includes changes done by hand), r=chutten.

Comment 13

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - Migrate histograms to use Glean APIs for ORB_*, r=chutten.

Comment 14

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - Migrate histograms to use Glean APIs for COOKIE_PURGING_*, r=chutten.

Comment 15

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - Migrate histograms to use Glean APIs in toolkit/components/antitracking, r=chutten.

Comment 16

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - Migrate histograms to use Glean APIs in toolkit/components/thumbnails, r=chutten.

Comment 17

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - Migrate histograms to use Glean APIs for CANVAS_*, r=chutten.

Comment 18

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - Migrate histograms to use Glean APIs for IMAGE_DECODE_*, r=chutten.

Comment 19

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - Migrate histograms to use Glean APIs for GPU_PROCESS_*, r=chutten.

Comment 20

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - Migrate histograms to use Glean APIs for DOWNLOADS_USER_ACTION_ON_BLOCKED_DOWNLOAD, r=chutten.

Comment 21

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - Migrate histograms to use Glean APIs for BFCACHE_*, r=chutten.

Comment 22

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - Migrate histograms to use Glean APIs for A11Y_*, r=chutten.

Comment 23

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - Migrate histograms to use Glean APIs for URLCLASSIFIER_*, r=chutten.

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb1f65b21001
Migrate histograms to use Glean APIs in toolkit/components/reputationservice, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/8076e1d66cd0
Migrate histograms to use Glean APIs in toolkit/components/reputationservice - migrate APPLICATION_REPUTATION_REASON by hand, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/02973e398381
Migrate histograms to use Glean APIs for CONTENT_PROCESS_*, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/5c410c78e0e4
Remove legacy histograms for GEOLOCATION_*, r=chutten,saschanaz.
https://hg.mozilla.org/integration/autoland/rev/525e894cea18
Migrate histograms to use Glean APIs for MEMORY_PHC_*, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/7b1a4410e075
Migrate histograms to use Glean APIs in nsCycleCollector.cpp, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/9b9e907f8eaa
Migrate histograms to use Glean APIs in CycleCollectorStats.cpp, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/98cec09004c6
Migrate histograms to use Glean APIs for remaining cycle collector histograms, r=chutten.

Comment 25

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - Migrate histograms to use Glean APIs for PREDICTOR_*, r=chutten.

Comment 26

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - Migrate histograms to use Glean APIs for STS_*, r=chutten.

Comment 27

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - Migrate histograms to use Glean APIs for FX_MIGRATION_*, r=chutten.

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d38219977e9
rewrite JS code storing histograms in local variables to make automatic glean migration easier, r=chutten,fxview-reviewers,sync-reviewers,anti-tracking-reviewers,places-reviewers,markh,nsharpley.
https://hg.mozilla.org/integration/autoland/rev/1be201b03db3
rewrite more JS code storing histograms in local variables (includes changes done by hand), r=chutten,search-reviewers,anti-tracking-reviewers,sessionstore-reviewers,dao.

Comment 29

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/bb1f65b21001
https://hg.mozilla.org/mozilla-central/rev/8076e1d66cd0
https://hg.mozilla.org/mozilla-central/rev/02973e398381
https://hg.mozilla.org/mozilla-central/rev/5c410c78e0e4
https://hg.mozilla.org/mozilla-central/rev/525e894cea18
https://hg.mozilla.org/mozilla-central/rev/7b1a4410e075
https://hg.mozilla.org/mozilla-central/rev/9b9e907f8eaa
https://hg.mozilla.org/mozilla-central/rev/98cec09004c6

Comment 30

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/1d38219977e9
https://hg.mozilla.org/mozilla-central/rev/1be201b03db3

Comment 31

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6fc9cb561771
Migrate histograms to use Glean APIs for fontlist, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/78a2ea73aa90
Migrate histograms to use Glean APIs in dom/crypto, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/54774b626c7c
Migrate histograms to use Glean APIs for ORB_*, r=chutten,valentin,sefeng.
https://hg.mozilla.org/integration/autoland/rev/83bb424c5b17
Migrate histograms to use Glean APIs for COOKIE_PURGING_*, r=chutten,anti-tracking-reviewers,emz.
https://hg.mozilla.org/integration/autoland/rev/85c6e5a114bf
Migrate histograms to use Glean APIs in toolkit/components/antitracking, r=chutten,anti-tracking-reviewers,firefox-desktop-core-reviewers ,emz,mossop.
https://hg.mozilla.org/integration/autoland/rev/39ed7d122140
Migrate histograms to use Glean APIs in toolkit/components/thumbnails, r=chutten.

Comment 32

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/574eaf273d35
Migrate histograms to use Glean APIs for GPU_PROCESS_*, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/dec3ce1ce618
Migrate histograms to use Glean APIs for DOWNLOADS_USER_ACTION_ON_BLOCKED_DOWNLOAD, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/57bd2b71efc0
Migrate histograms to use Glean APIs for BFCACHE_*, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/7a03d0f184b3
Migrate histograms to use Glean APIs for A11Y_*, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/075ab7d73a4a
Migrate histograms to use Glean APIs for URLCLASSIFIER_*, r=chutten.

Comment 33

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c46d3b1f78c7
Migrate histograms to use Glean APIs for PREDICTOR_*, r=chutten,necko-reviewers,valentin.
https://hg.mozilla.org/integration/autoland/rev/da42ecdb2d64
Migrate histograms to use Glean APIs for STS_*, r=chutten,necko-reviewers,kershaw.
https://hg.mozilla.org/integration/autoland/rev/ce5a83e9991c
Migrate histograms to use Glean APIs for FX_MIGRATION_*, r=chutten,migration-reviewers,mconley.

Comment 34

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - Migrate histograms to use Glean APIs for MIXED_CONTENT_*, r=chutten.

Comment 35

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - Migrate histograms to use Glean APIs in network/cache2, r=chutten.

Comment 36

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - Migrate histograms to use Glean APIs in dom/storage, r=chutten.

Comment 37

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - Migrate histograms to use Glean APIs in netwerk/dns (excluding keyed boolean and categorical histograms that are not supported in Glean yet), r=chutten.

Comment 38

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - Migrate histograms to use Glean APIs for CERT_*, r=chutten.

Comment 39

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - Migrate histograms to use Glean APIs for SSL_HANDSHAKE_*, r=chutten.

Comment 40

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - Migrate histograms to use Glean APIs for remaining SSL_* histograms, r=chutten.

Comment 41

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc2eb0d65829
Migrate histograms to use Glean APIs for CANVAS_*, r=chutten,jgilbert.

Comment 42

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/6fc9cb561771
https://hg.mozilla.org/mozilla-central/rev/78a2ea73aa90
https://hg.mozilla.org/mozilla-central/rev/54774b626c7c
https://hg.mozilla.org/mozilla-central/rev/83bb424c5b17
https://hg.mozilla.org/mozilla-central/rev/85c6e5a114bf
https://hg.mozilla.org/mozilla-central/rev/39ed7d122140
https://hg.mozilla.org/mozilla-central/rev/574eaf273d35
https://hg.mozilla.org/mozilla-central/rev/dec3ce1ce618
https://hg.mozilla.org/mozilla-central/rev/57bd2b71efc0
https://hg.mozilla.org/mozilla-central/rev/7a03d0f184b3
https://hg.mozilla.org/mozilla-central/rev/075ab7d73a4a
https://hg.mozilla.org/mozilla-central/rev/c46d3b1f78c7
https://hg.mozilla.org/mozilla-central/rev/da42ecdb2d64
https://hg.mozilla.org/mozilla-central/rev/ce5a83e9991c
https://hg.mozilla.org/mozilla-central/rev/fc2eb0d65829

Comment 43

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - Migrate histograms to use Glean APIs for WEBRTC_*, r=chutten.

Comment 44

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - Migrate histograms to use Glean APIs for MEDIA_MP4_PARSE_*, r=chutten.

Comment 45

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - remove legacy telemetry histograms MEDIA_AUDIO_INIT_FAILURE and bug MEDIA_AUDIO_BACKEND that are already in Glean, r=padenot,chutten.

Comment 46

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - Migrate histograms to use Glean APIs in toolkit/components/mediasniffer, r=chutten.

Comment 47

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - Migrate histograms to use Glean APIs in dom/media/utils/TelemetryProbesReporter.cpp, r=chutten.

Comment 48

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - Migrate histograms to use Glean APIs for remaining media histograms, r=chutten.

Comment 49

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - remove remaining legacy telemetry references in dom/media, r=chutten.

Comment 50

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - Migrate histograms to use Glean APIs in netwerk/protocol/http/Http2Compression, r=chutten.

Comment 51

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - Migrate histograms to use Glean APIs for SPDY_*, r=chutten.

Comment 52

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - Migrate histograms to use Glean APIs for HTTP_*, r=chutten.

Comment 53

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - Migrate histograms to use Glean APIs for http TRANSACTION_*, r=chutten.

Comment 54

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - Migrate histograms to use Glean APIs for NETWORK_RACE_CACHE_*, r=chutten.

Comment 55

[Florian Quèze [:florian]]

Attachment: Bug 1935420 - Migrate histograms to use Glean APIs for remaining NETWORK_* histograms in netwerk/protocol/http, r=chutten.

Comment 56

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dbafa2c05091
Migrate histograms to use Glean APIs for IMAGE_DECODE_*, r=chutten.

Comment 57

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/199508b45022
Migrate histograms to use Glean APIs for WEBRTC_*, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/bc766bf0cf6f
Migrate histograms to use Glean APIs for MEDIA_MP4_PARSE_*, r=chutten.
https://hg.mozilla.org/integration/autoland/rev/875fa0531276
remove legacy telemetry histograms MEDIA_AUDIO_INIT_FAILURE and bug MEDIA_AUDIO_BACKEND that are already in Glean, r=padenot,chutten.

Comment 58

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/dbafa2c05091
https://hg.mozilla.org/mozilla-central/rev/199508b45022
https://hg.mozilla.org/mozilla-central/rev/bc766bf0cf6f
https://hg.mozilla.org/mozilla-central/rev/875fa0531276

Comment 59

[Phabricator Automation]

Comment on attachment 9461948 [details]
Bug 1935420 - Migrate histograms to use Glean APIs for MIXED_CONTENT_*, r=chutten.

Revision D235629 was moved to bug 1944631. Setting attachment 9461948 [details] to obsolete.

Comment 60

[Phabricator Automation]

Comment on attachment 9461949 [details]
Bug 1935420 - Migrate histograms to use Glean APIs in network/cache2, r=chutten.

Revision D235630 was moved to bug 1944631. Setting attachment 9461949 [details] to obsolete.

Comment 61

[Phabricator Automation]

Comment on attachment 9461951 [details]
Bug 1935420 - Migrate histograms to use Glean APIs in dom/storage, r=chutten.

Revision D235631 was moved to bug 1944631. Setting attachment 9461951 [details] to obsolete.

Comment 62

[Phabricator Automation]

Comment on attachment 9461952 [details]
Bug 1935420 - Migrate histograms to use Glean APIs in netwerk/dns (excluding keyed boolean and categorical histograms that are not supported in Glean yet), r=chutten.

Revision D235632 was moved to bug 1944631. Setting attachment 9461952 [details] to obsolete.

Comment 63

[Phabricator Automation]

Comment on attachment 9462003 [details]
Bug 1935420 - Migrate histograms to use Glean APIs for CERT_*, r=chutten.

Revision D235664 was moved to bug 1944631. Setting attachment 9462003 [details] to obsolete.

Comment 64

[Phabricator Automation]

Comment on attachment 9462004 [details]
Bug 1935420 - Migrate histograms to use Glean APIs for SSL_HANDSHAKE_*, r=chutten.

Revision D235665 was moved to bug 1944631. Setting attachment 9462004 [details] to obsolete.

Comment 65

[Phabricator Automation]

Comment on attachment 9462019 [details]
Bug 1935420 - Migrate histograms to use Glean APIs for remaining SSL_* histograms, r=chutten.

Revision D235673 was moved to bug 1944631. Setting attachment 9462019 [details] to obsolete.

Comment 66

[Phabricator Automation]

Comment on attachment 9462489 [details]
Bug 1935420 - Migrate histograms to use Glean APIs in toolkit/components/mediasniffer, r=chutten.

Revision D235953 was moved to bug 1944631. Setting attachment 9462489 [details] to obsolete.

Comment 67

[Phabricator Automation]

Comment on attachment 9462490 [details]
Bug 1935420 - Migrate histograms to use Glean APIs in dom/media/utils/TelemetryProbesReporter.cpp, r=chutten.

Revision D235954 was moved to bug 1944631. Setting attachment 9462490 [details] to obsolete.

Comment 68

[Phabricator Automation]

Comment on attachment 9462491 [details]
Bug 1935420 - Migrate histograms to use Glean APIs for remaining media histograms, r=chutten.

Revision D235955 was moved to bug 1944631. Setting attachment 9462491 [details] to obsolete.

Comment 69

[Phabricator Automation]

Comment on attachment 9462492 [details]
Bug 1935420 - remove remaining legacy telemetry references in dom/media, r=chutten.

Revision D235956 was moved to bug 1944631. Setting attachment 9462492 [details] to obsolete.

Comment 70

[Phabricator Automation]

Comment on attachment 9462493 [details]
Bug 1935420 - Migrate histograms to use Glean APIs in netwerk/protocol/http/Http2Compression, r=chutten.

Revision D235957 was moved to bug 1944631. Setting attachment 9462493 [details] to obsolete.

Comment 71

[Phabricator Automation]

Comment on attachment 9462494 [details]
Bug 1935420 - Migrate histograms to use Glean APIs for SPDY_*, r=chutten.

Revision D235958 was moved to bug 1944631. Setting attachment 9462494 [details] to obsolete.

Comment 72

[Phabricator Automation]

Comment on attachment 9462495 [details]
Bug 1935420 - Migrate histograms to use Glean APIs for HTTP_*, r=chutten.

Revision D235959 was moved to bug 1944631. Setting attachment 9462495 [details] to obsolete.

Comment 73

[Phabricator Automation]

Comment on attachment 9462496 [details]
Bug 1935420 - Migrate histograms to use Glean APIs for http TRANSACTION_*, r=chutten.

Revision D235960 was moved to bug 1944631. Setting attachment 9462496 [details] to obsolete.

Comment 74

[Phabricator Automation]

Comment on attachment 9462497 [details]
Bug 1935420 - Migrate histograms to use Glean APIs for NETWORK_RACE_CACHE_*, r=chutten.

Revision D235961 was moved to bug 1944631. Setting attachment 9462497 [details] to obsolete.

Comment 75

[Phabricator Automation]

Comment on attachment 9462498 [details]
Bug 1935420 - Migrate histograms to use Glean APIs for remaining NETWORK_* histograms in netwerk/protocol/http, r=chutten.

Revision D235962 was moved to bug 1944631. Setting attachment 9462498 [details] to obsolete.

Comment 76

[Florian Quèze [:florian]]

Attachment: eslint-rule.patch

For future reference, I'm attaching a patch adding the eslint rule I used to generate D234008.

Comment 77

[Florian Quèze [:florian]]

Attachment: eslint-rule-made-more-aggressive.patch

I'm attaching the patch (applying on top of attachment 9462761 [details] [diff] [review]) that helped to generate https://phabricator.services.mozilla.com/D234009