1938261 - AI chatbot shortcut should be disabled if AI chatbot feature is turned off

Status: VERIFIED FIXED

(Core :: Machine Learning: General, defect)

Description

[Tooru Fujisawa [:arai]]

Steps to reproduce:

1. Run Firefox Nightly 135.0a1 (2024-12-18) (aarch64) on macOS with clean profile
2. open about:preferences#experimental and ensure the "AI chatbot" checkbox is not checked
3. hit ctrl+x
4. hit ctrl+x again

Actual result:
In the step 3, the "AI Chatbot" sidebar is opened, and the "AI chatbot" checkbox in the about:preferences#experimental is checked
In the step 4, the "AI Chatbot" sidebar is closed, and the "AI chatbot" checkbox remains checked.

Expected result:
The ctrl+x does nothing as long as the "AI chatbot" checkbox is not checked.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:tarek, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Tooru Fujisawa [:arai]]

According to the code added by bug 1905027, it's intentional that the shortcut is enabled even if the feature is disabled and the feature is enabled by the shortcut,
and also there's telemetry for the usage whether the pref was enabled or not.

Then, the bug's STR explicitly mentions "Enable the AI Chat integration" as a preparation. so enabling the pref on shortcut doesn't match what the bug is about.

Can we revisit the decision there?

Comment 3

[Tooru Fujisawa [:arai]]

This behavior is causing another trouble that the AI chatbot menu item is shown in the context menu whenever I accidentally hit ctrl+x, and it's kept shown until I manually flip the pref. Even if the immediate action for the shortcut is "open a sidebar", closing the sidebar doesn't reset the state.
IMO, having a shortcut key with this consequence isn't much intuitive.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1905027

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1938261 - Make the AI chatbot keyboard shortcut no-op when the feature is disabled. r?Mardak!

Given the chatbot feature is now enabled by default, the pref being disabled
means explicitly turned off. The shortcut key shouldn't turn it back to on.

Comment 6

[Ed Lee :Mardak]

sounds reasonable given that it's enabled by default now

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa6015b2eb0b
Make the AI chatbot keyboard shortcut no-op when the feature is disabled. r=Mardak,firefox-ai-ml-reviewers

Comment 8

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/aa6015b2eb0b

Comment 9

[Donal Meehan [:dmeehan]]

:arai does this need a beta uplift request for Fx136 or should it ride the train with Fx137?

Comment 10

[Tooru Fujisawa [:arai]]

Given the feature is enabled by default by bug 1933524 patch, which targets 136, it would be nice to fix this on 136 as well,
but I'd like to ask Mardak for the decision, given there's also telemetry around the branch.

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:arai, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox136 to wontfix.

For more information, please visit BugBot documentation.

Comment 12

[Ed Lee :Mardak]

yeah we can uplift to 136 as that's where we've enabled by default and will keep in mind when analyzing the telemetry

Comment 13

[Tooru Fujisawa [:arai]]

Attachment: Bug 1938261 - Make the AI chatbot keyboard shortcut no-op when the feature is disabled. r?Mardak!

Given the chatbot feature is now enabled by default, the pref being disabled
means explicitly turned off. The shortcut key shouldn't turn it back to on.

Original Revision: https://phabricator.services.mozilla.com/D236477

Comment 14

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Shortcut key enables the AI chatbot feature even after explicitly turned off
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: none
• Risk associated with taking this patch: low
• Explanation of risk level: This behavior is observed only when hitting shortcut key after turning off the AI chatbot feature explicitly from config
• String changes made/needed: none
• Is Android affected?: no

Comment 15

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/27969df21f9f

Comment 16

[Rares Doghi, Desktop QA]

This issue still occurs in our latest Nightly build , The Shortcut for the Ai Chat on Windows is Ctrl+Alt+X and it still opens the AI chat panel even if the tool is unchecked from Settings, @Tooru can you take a look at this ?

Comment 17

[Ed Lee :Mardak]

this is for the old sidebar (so no checkbox to uncheck). it would need to be turned off via about:config browser.ml.chat.enabled

i'm seeing the desired behavior on nightly and beta

Comment 18

[Rares Doghi, Desktop QA]

Since this is about the old sidebar I can Confirm that its verified as Fixed in our latest Nightly as well as beta 136.0b4