1938425 - Record telemetry event when reopening a saved tab group

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, task, P2)

Description

[Stephen Thompson [:sthompson]]

Event category: tabgroup
Event name: reopen
Description: Recorded when the user re-opens a saved tab group
Extras:

• source (string): "tab_overflow" | "suggest" | "recent"
• layout (string): "horizontal" | "vertical"
• id (string): tab group ID to correlate multiple events affecting the same tab group

This event should fire when the user reopens a saved tab group by using any of the following:

1. the all tabs menu/tab overflow menu
2. the URL bar/awesome bar/search + suggest when typing the group name into the URL bar and selecting it
3. the recently closed tabs menus

Comment 1

[DJ]

as noted in bug 1957488 we are also adding the following key:

• type (string): "saved" | "deleted"

Comment 2

[DJ]

Attachment: Bug 1938425 - add telemetry for reopening saved groups. r?dao,jswinarton,vsabino

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c700c5b8a89
add telemetry for reopening saved groups. r=dao,sessionstore-reviewers,tabbrowser-reviewers,urlbar-reviewers,sthompson

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_tab_groups_telemetry.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/279ac91bc0f7425fd584d743bb7c30373557bb66

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/tabbrowser/test/browser/tabs/browser_tab_groups_telemetry.js

 Buffered messages finished
[task 2025-04-07T16:15:47.714Z] 16:15:47     INFO - TEST-UNEXPECTED-FAIL | browser/components/tabbrowser/test/browser/tabs/browser_tab_groups_telemetry.js | 1 group in menu - 3 == 1 - 
[task 2025-04-07T16:15:47.714Z] 16:15:47     INFO - Stack trace:
[task 2025-04-07T16:15:47.714Z] 16:15:47     INFO - chrome://mochitests/content/browser/browser/components/tabbrowser/test/browser/tabs/browser_tab_groups_telemetry.js:doReopenTests:512
[task 2025-04-07T16:15:47.714Z] 16:15:47     INFO - chrome://mochitests/content/browser/browser/components/tabbrowser/test/browser/tabs/browser_tab_groups_telemetry.js:test_reopenSavedGroupTelemetry:569
[task 2025-04-07T16:15:47.714Z] 16:15:47     INFO - chrome://mochikit/content/browser-test.js:handleTask:1170
[task 2025-04-07T16:15:47.714Z] 16:15:47     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1242
[task 2025-04-07T16:15:47.714Z] 16:15:47     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1383
[task 2025-04-07T16:15:47.714Z] 16:15:47     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1159
[task 2025-04-07T16:15:47.714Z] 16:15:47     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2025-04-07T16:15:47.715Z] 16:15:47     INFO - TEST-PASS | browser/components/tabbrowser/test/browser/tabs/browser_tab_groups_telemetry.js | Correct group appears in menu - "1744042547350-69" == "1744042547350-69" - 
[task 2025-04-07T16:15:47.715Z] 16:15:47     INFO - TEST-PASS | browser/components/tabbrowser/test/browser/tabs/browser_tab_groups_telemetry.js | should have recorded one tabgroup.reopen event - 1 == 1 - 
[task 2025-04-07T16:15:47.716Z] 16:15:47     INFO - TEST-PASS | browser/components/tabbrowser/test/browser/tabs/browser_tab_groups_telemetry.js | should have recorded correct id, source, and layout for reopen event - {"type":"saved","source":"tab_overflow","layout":"horizontal","id":"1744042547350-69"} deepEqual {"id":"1744042547350-69","source":"tab_overflow","layout":"horizontal","type":"saved"} - 
[task 2025-04-07T16:15:47.717Z] 16:15:47     INFO - GECKO(1795) | console.error: "Given tab is not restoring."
[task 2025-04-07T16:15:47.717Z] 16:15:47     INFO - restoring saved group via undoClosetab
[task 2025-04-07T16:15:47.718Z] 16:15:47     INFO - TEST-PASS | browser/components/tabbrowser/test/browser/tabs/browser_tab_groups_telemetry.js | should have recorded one tabgroup.reopen event - 1 == 1 - 
[task 2025-04-07T16:15:47.719Z] 16:15:47     INFO - TEST-PASS | browser/components/tabbrowser/test/browser/tabs/browser_tab_groups_telemetry.js | should have recorded correct id, source, and layout for reopen event - {"layout":"horizontal","source":"recent","type":"saved","id":"1744042547350-69"} deepEqual {"id":"1744042547350-69","source":"recent","layout":"horizontal","type":"saved"} - 
[task 2025-04-07T16:15:47.723Z] 16:15:47     INFO - restoring saved group from URLbar suggestion
[task 2025-04-07T16:15:47.727Z] 16:15:47     INFO - GECKO(1795) | console.log: "Waiting for the urlbar view to open"
[task 2025-04-07T16:15:47.803Z] 16:15:47     INFO - GECKO(1795) | console.log: "Urlbar view opened"
[task 2025-04-07T16:15:57.612Z] 16:15:57     INFO - Not taking screenshot here: see the one that was previously logged
[task 2025-04-07T16:15:57.612Z] 16:15:57     INFO - TEST-UNEXPECTED-FAIL | browser/components/tabbrowser/test/browser/tabs/browser_tab_groups_telemetry.js | Uncaught exception in test bound test_reopenSavedGroupTelemetry - Waiting for reopen telemetry to populate - timed out after 50 tries.
[task 2025-04-07T16:15:57.613Z] 16:15:57     INFO - Leaving test bound test_reopenSavedGroupTelemetry
[task 2025-04-07T16:15:57.679Z] 16:15:57     INFO - GECKO(1795) | MEMORY STAT | vsize 25015MB | residentFast 693MB | heapAllocated 227MB
[task 2025-04-07T16:15:57.680Z] 16:15:57     INFO - TEST-OK | browser/components/tabbrowser/test/browser/tabs/browser_tab_groups_telemetry.js | took 13182ms
[task 2025-04-07T16:15:57.680Z] 16:15:57     INFO - Not taking screenshot here: see the one that was previously logged
[task 2025-04-07T16:15:57.681Z] 16:15:57     INFO - TEST-UNEXPECTED-FAIL | browser/components/tabbrowser/test/browser/tabs/browser_tab_groups_telemetry.js | Found an unexpected tab at the end of test run: about:blank - 
[task 2025-04-07T16:15:57.696Z] 16:15:57     INFO - checking window state
[task 2025-04-07T16:15:57.714Z] 16:15:57     INFO - TEST-START | browser/components/tabbrowser/test/browser/tabs/browser_tab_label_during_reload.js

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7fed35bbd242
add telemetry for reopening saved groups. r=dao,sessionstore-reviewers,tabbrowser-reviewers,urlbar-reviewers,sthompson

Comment 6

[Cristina Horotan [:chorotan]]

Backed out for causing bc failures at browser_tab_groups_telemetry.js

Backout link

Push with failures

Failure log

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4711e76ce475
add telemetry for reopening saved groups. r=dao,sessionstore-reviewers,tabbrowser-reviewers,urlbar-reviewers,sthompson

Comment 8

[Atila Butkovits]

Backed out for causing failures at browser_tab_groups_telemetry.js.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/b023979f70cbb14442c57729960e765b2107bee3

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=4711e76ce47524cb4a05e38a77a27d2d55e291c0&selectedTaskRun=MNgTaKDWRGyUsm0DGzhl6Q.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=503241285&repo=autoland&lineNumber=7877

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88662e13869c
add telemetry for reopening saved groups. r=dao,sessionstore-reviewers,tabbrowser-reviewers,urlbar-reviewers,sthompson

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/88662e13869c

Comment 11

[DJ]

Attachment: Bug 1938425 - add telemetry for reopening saved groups. r?dao,jswinarton,vsabino

Original Revision: https://phabricator.services.mozilla.com/D243737

Comment 12

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: No user impact, but will impact data gathering for tab groups; specifically, user behavior around reopening saved groups
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: low
• Explanation of risk level: adds telemetry, no user-facing changes
• String changes made/needed: none
• Is Android affected?: no

Comment 13

[Dianna Smith [:diannaS]]

:dwalker wouldnt we need to uplift bug 1959981 as well?

Comment 14

[DJ]

(In reply to Dianna Smith [:diannaS] from comment #13)

:dwalker wouldnt we need to uplift bug 1959981 as well?

I left a comment in the patch; I needed to rebase for the uplift patch so I went ahead and included that one-line fix along with it. It's a straightforward fix but we can wait for that to be reviewed or I can ask a peer to review the uplift request if you'd like.

Comment 15

[DJ]

actually, disregard the above - my try run is suggesting that patch doesn't fix the issue.

Comment 16

[Dão Gottwald [:dao]]

(In reply to DJ (:dwalker) from comment #15)

actually, disregard the above - my try run is suggesting that patch doesn't fix the issue.

Just to explicitly close the loop here, from what I understand DJ has resolved this issue now and both patches should be good to go for beta.

Comment 17

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/793095ea2cab