1938430 - Record telemetry event when deleting a tab group

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, task, P2)

Description

[Stephen Thompson [:sthompson]]

Event category: tabgroup
Event name: delete
Description: Recorded when the user deletes a tab group
Additional data:

• id (string): group ID of the tab group being deleted
• source (string): tab_overflow if the user right-clicked a group in the tab overflow menu and chose "Delete group"; tab_group if the user right-clicked a tab group's label and chose "Delete group"

When the user performs "delete group" on an open tab group, the tab group becomes closed. The closed tab group is still visible in "recently closed tabs" and the tab overflow menu. When the user performs "delete group" on a closed tab group, the closed group is forgotten by session state and is no longer present in the tab overflow menu. The meaning of "delete" is somewhat different in these cases.

The session store forgets about closed groups during its daily cleanup. This is equivalent to "delete group" but it's automated and not driven by user intent. This bug will not instrument the automated cleanup.

Comment 1

[Stephen Thompson [:sthompson]]

Attachment: Bug 1938430 - add delete tab group event r=dao,dwalker,jswinarton

Record when users delete an open group from the tab group context menu, delete an open group from a context menu in the all-tabs menu, or delete/forget a saved group from a context menu in the all-tabs menu.

This will not record when users close a window or close all of the individual tabs in a tab group, even though those cases have the logical side effect of deleting a tab group.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/68d101b370d8
add delete tab group event r=jswinarton,tabbrowser-reviewers,sessionstore-reviewers

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/68d101b370d8

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1b5d6e0f034
Backed out changeset 68d101b370d8 for permafailures on browser_tab_manager_groups.js (Bug 1938697).

Comment 5

[Cosmin Sabou [:CosminS]]

Backed out changeset 68d101b370d8 (Bug 1938430) for permafailures on browser_tab_manager_groups.js (Bug 1938697).

Push with failures

Failure log

Backout link

Comment 6

[Norisz Fay [:noriszfay]]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/f1b5d6e0f034

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45b8edc68591
add delete tab group event r=jswinarton,tabbrowser-reviewers,sessionstore-reviewers

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/45b8edc68591

Comment 9

[Stephen Thompson [:sthompson]]

Attachment: Bug 1938430 - add delete tab group event r=dao,dwalker,jswinarton

Record when users delete an open group from the tab group context menu or delete an open group from a context menu in the all-tabs menu.

This will not record when users close a window or close all of the individual tabs in a tab group, even though those cases have the logical side effect of deleting a tab group.

Original Revision: https://phabricator.services.mozilla.com/D241884

Comment 10

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: No user impact. If declined, the Firefox Desktop team will have less insight into how and whether users are deleting tab groups after creating them
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: Right-click a tab group label, choose Delete group, note the metric event being recorded. Open all tabs menu, right-click a tab group, and choose Delete group. Note that the delete group event metric is recorded.
• Risk associated with taking this patch: Low
• Explanation of risk level: Adds additional Glean calls, which should not cause errors for users if something goes wrong. This patch adds additional optional parameters to some existing functions, but no browser logic changed.
• String changes made/needed: No
• Is Android affected?: no

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/9e8c5153617b