1938437 - Address bar autocompletion suggestions jiggle up and down when I hover/unhover suggestions that have a badge for being a sync'ed tab

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Daniel Holbert [:dholbert]]

I'm still seeing a version of bug 1901161 for synced tabs -- mbeier, maybe you'd be up for taking a look, since you looked at bug 1901161?

STR:

1. Sign into a Firefox account in two different Firefox profiles (e.g. on two different machines)
2. Visit https://example.org on one profile (let's call this the "remote profile"), and trigger a sync (Tools | Sync Now) to be sure that gets noticed.
3. On your other profile (let's call it the "local profile"), trigger a sync to be sure it's aware that example.org is open elsewhere.
4. Still on the local profile, focus your URLbar and type "example".
5. Hover the autocomplete suggestion for the remote tab at example.org , or traverse it using uparrow/downarrow to move the selection-highlight.

ACTUAL RESULTS:
When the autocomplete suggestion is hovered or selected, the synced-tab badge disappears and that seems to make the entry get ever-so-slightly shorter (the same as in bug 1901161), and that makes the following content jiggle upwards slightly.

EXPECTED RESULTS:
No such jiggling (no such change in height when the badge disappears)

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screencast showing the bug

Comment 2

[Moritz Beier [:mbeier]]

Attachment: Bug 1938437 - Preserve row height of all urlbar results when action button is toggled. r?dao

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e3e99bc80998
Preserve row height of all urlbar results when action button is toggled. r=dao,desktop-theme-reviewers,urlbar-reviewers

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/e3e99bc80998

Comment 5

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2024-12-19 Nightly build on Windows 10.
Verified as fixed on Firefox Nightly 136.0a1 and Firefox 135.0b8 on Windows 10, Ubuntu 22, macOS 14.