1901161 - Address bar autocompletion panel (and its contents) jiggle up and down when I press Ctrl, as "Switch to tab" buttons get converted to URLs

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Daniel Holbert [:dholbert]]

Attachment: screencast of bug

STR:

1. Have several tabs open with "todo" in the title (the exact string doesn't matter, that's just what I happened to use to trigger it). e.g. these ones:
   https://bugzilla.mozilla.org/show_bug.cgi?id=1846560
   https://bugzilla.mozilla.org/show_bug.cgi?id=1874079

2. Focus your address bar and type "todo"

3. Press Ctrl, and then release Ctrl (to toggle between "Switch to tab" and URLs)

EXPECTED RESULTS:
No change in heights/vertical-positioning.

ACTUAL RESULTS:

• Everything after the first switch-to-tab suggestion moves up a bit when I press ctrl (and the buttons disappear)
• This means the bottom border of the whole autosuggestion panel itself moves up a little bit
• It looks like the autocomplete suggestions get very-slightly-shorter when I press Ctrl, I think?

Comment 1

[Daniel Holbert [:dholbert]]

regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=792fcb4ab1abdc2bcdb15cc6a43f09115a14c746&tochange=dc7196a81613583024a297e0d39eee8205437dbb

--> Regression from bug 1886761, which shipped in 126 release (I just confirmed this reproduces in 126 release builds, too).

So almost certainly wontfix for 127 which is about to be released -- setting that status. Maybe we can fix for 128, though -- Dão, could you take a look?

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: screencast (more zoomed in, to make it a little easier to see)

Here's a screencast focusing in on the area where the badness happens, to perhaps make this easier to see.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1886761

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

Because of the severity and priority rating, I'm marking this fix-optional for current releases, since the team is aware and has rated the issue.

While we are happy to take a patch, and uplift if it's requested, we don't need to keep looking at the bug in weekly regression triage.

Comment 5

[Daniel Holbert [:dholbert]]

Attachment: screencast of this affecting a Google Suggesiton and its preview-image

Not a huge surprise, but just FWIW, this affects the location bar's "Google Suggestions" and their preview-images, too. Here's a screencast of this happening for me just now in Firefox Nightly 131.0a1 (2024-08-29) (64-bit), with the "Among us" title and preview-image snapping up and down as I press/release my Ctrl key.

It feels a bit more noticeable to me when there's a large thing like a preview-image wiggling (as opposed to just text and/or a smaller favicon).

Comment 6

[Moritz Beier [:mbeier]]

Attachment: Bug 1901161 - Preserve row height of switch-to-tab results in action override mode, i.e. while pressing Shift or Ctrl.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0e3d8a99094
Preserve row height of switch-to-tab results in action override mode, i.e. while pressing Shift or Ctrl. r=dao,desktop-theme-reviewers,urlbar-reviewers

Comment 8

[amarc]

https://hg.mozilla.org/mozilla-central/rev/a0e3d8a99094

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mbeier, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox134 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on Firefox 134.0b10 on Windows 10.
Verified as fixed on Firefox Nightly 135.0a1 on Windows 10, Ubuntu 22, macOS 14.