1938443 - Address bar has no spacing between the "switch to tab" badge and the URL, with Unified Search Button (scotch bonnet) enabled

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Daniel Holbert [:dholbert]]

Attachment: screenshot of bug

STR:

1. Visit https://example.org/
2. Open a new tab and type "example"
3. Press downarrow to focus the Firefox Suggest suggestion to switch-to-tab.
4. Look at your URL bar.

EXPECTED RESULTS:
There should be some space between the right edge of the Switch to tab: badge and the URL itself (the leading "h" character)

ACTUAL RESULTS:
There's no space between them; the rightmost pixel of the badge is directly adjacent to the leftmost (antialiased) pixel of the "h" in the URL.

Notes:

• After reproducing the bug, if I press Ctrl to hide the Switch-to-tab badge (so that the address bar just shows the unified-search-button and the URL), then I get expected-results in that context -- there's space to the left of the "h".
• If I set browser.urlbar.scotchBonnet.enableOverride to false, I get EXPECTED RESULTS. Interestingly, the URL remains in precisely the same pixel location (as you can see in upcoming screenshots if you open them in side-by-side tabs and compare back and forth); but the buttons to the left of the URL just get a bit skinnier which leaves a reasonable amount of space.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screenshot of expected-results when I disable the scotchBonnet pref

Comment 2

[Daniel Holbert [:dholbert]]

This is a regression, with regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=84e4d86608d2fac91800141895688f119864d005&tochange=5c927e89451bcf64289953bc6e478bfe3197cb3a

In Nightly builds before that range, the "switch to tab" button is to the left of the unified-search-button, and there's no spacing between those two buttons (which is maybe just a version of the same underlying problem, moved to a different location). But I'm considering builds before that^ range "good" from the perspective of "is the URL itself preceded by some spacing" [it is].

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1928132

:daisuke, since you are the author of the regressor, bug 1928132, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 4

[Marco Bonardo [:mak]]

(In reply to Daniel Holbert [:dholbert] from comment #2)

This is a regression, with regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=84e4d86608d2fac91800141895688f119864d005&tochange=5c927e89451bcf64289953bc6e478bfe3197cb3a

In Nightly builds before that range, the "switch to tab" button is to the left of the unified-search-button

that was a bug, bug 1928132 fixed that, but there's some spacing adjustment to make

Comment 5

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1938443: Add margin between identity box and input field

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f858bf1dd20
Add margin between identity box and input field r=dao,daleharvey

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/4f858bf1dd20

Comment 8

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2024-12-19 Nightly build on Windows 10.
Verified as fixed on Firefox Nightly 135.0a1 on Windows 10, Ubuntu 22, macOS 14.