1938452 - Move most of browser/components/newtab under a new folder browser/extensions/newtab

Status: RESOLVED FIXED

(Firefox :: New Tab Page, task)

Description

[Mike Conley (:mconley) (:⚙️)]

We're going to be moving anything that should be included in the built-in addon. That's almost everything under browser/components/newtab, except for:

• nsIAboutNewTabService.idl
  • This is the XPCOM interface file for the nsIAboutNewTabService, which allows our native code to get information about New Tab’s configuration. It also helps power the about:home startup cache.
  • Currently, this is no way (and unlikely to ever be a way) to update XPCOM interfaces at runtime via privileged WebExtension, so we should leave this in browser/components/newtab.
• AboutNewTabService.sys.mjs
• AboutNewTab.sys.mjs

Comment 1

[Mike Conley (:mconley) (:⚙️)]

The timing of this is going to be critical, as we'll want to do this work at a point where it's going to cause the least disruption to ongoing work in browser/components/newtab. I agree with Scott when he says "I think there are not a lot of good times, but there is a bad time (to do this work)".

I'm going to tentatively aim to have us do this at the start of the 136 Nightly cycle, which is February 3rd 2025.

To be clear, beyond moving the location of the files, there should be no change to the development methodology for New Tab.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1938452 - Stub out browser/extensions/newtab. r?#home-newtab-reviewers!,pdahiya!

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1938452 - Move newtab documentation to browser/extensions/newtab. r?#home-newtab-reviewers!

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1938452 - Move newtab support code to browser/extensions/newtab. r?#home-newtab-reviewers!

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1938452 - Move newtab utility scripts to browser/extensions/newtab. r?#home-newtab-reviewers!

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1938452 - Move newtab content source code and build scripts to browser/extensions/newtab. r?#home-newtab-reviewers!

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1938452 - Update license.yml mapping to browser/extensions/newtab. r?#linter-reviewers!

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1938452 - Update rejected-words.yml mapping to browser/extensions/newtab. r?#linter-reviewers!

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1938452 - Move newtab tests to browser/extensions/newtab. r?#home-newtab-reviewers!

Comment 10

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1938452 - Update a bunch of non-permalink references to browser/extensions/newtab. r?#home-newtab-reviewers!

Comment 11

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1938452 - Update mots so that New Tab module includes browser/extensions/newtab as well. r?zeid!

Comment 12

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1938452 - Move browser/components/newtab eslintrc rules to browser/extensions/newtab. r?#home-newtab-reviewers!

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd4fdafb2594
Stub out browser/extensions/newtab. r=pdahiya,home-newtab-reviewers,amy
https://hg.mozilla.org/integration/autoland/rev/88df910fa038
Move newtab documentation to browser/extensions/newtab. r=omc-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,pdahiya,mossop,amy
https://hg.mozilla.org/integration/autoland/rev/8ca1a633192a
Move newtab support code to browser/extensions/newtab. r=home-newtab-reviewers,nbarrett
https://hg.mozilla.org/integration/autoland/rev/aef74a3d077d
Move newtab utility scripts to browser/extensions/newtab. r=home-newtab-reviewers,amy
https://hg.mozilla.org/integration/autoland/rev/f1f41e902e36
Move newtab content source code and build scripts to browser/extensions/newtab. r=home-newtab-reviewers,nbarrett,thecount
https://hg.mozilla.org/integration/autoland/rev/ac0a50aaf347
Update rejected-words.yml mapping to browser/extensions/newtab. r=linter-reviewers,sylvestre
https://hg.mozilla.org/integration/autoland/rev/c9737e213e42
Move newtab tests to browser/extensions/newtab. r=home-newtab-reviewers,omc-reviewers,frontend-codestyle-reviewers,pdahiya,thecount
https://hg.mozilla.org/integration/autoland/rev/9c8837fc4805
Update a bunch of non-permalink references to browser/extensions/newtab. r=sylvestre,search-reviewers,tabbrowser-reviewers,omc-reviewers,android-reviewers,home-newtab-reviewers,frontend-codestyle-reviewers,mcheang,pdahiya,thecount,dao,pollymce
https://hg.mozilla.org/integration/autoland/rev/69f385bc90ce
Update mots so that New Tab module includes browser/extensions/newtab as well. r=zeid
https://hg.mozilla.org/integration/autoland/rev/f6a771e83261
Move browser/components/newtab eslintrc rules to browser/extensions/newtab. r=home-newtab-reviewers,frontend-codestyle-reviewers,Standard8,thecount

Comment 14

[amarc]

Backed out for causing node failures

• Backout link
• Push with failures
• Failure Log
• Failure line:

TEST-UNEXPECTED-FAIL | bundles | Activity Stream bundle out of date

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e1f12f800782
Stub out browser/extensions/newtab. r=pdahiya,home-newtab-reviewers,amy
https://hg.mozilla.org/integration/autoland/rev/cb931e962950
Move newtab documentation to browser/extensions/newtab. r=omc-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,pdahiya,mossop,amy
https://hg.mozilla.org/integration/autoland/rev/a440ddfb8782
Move newtab support code to browser/extensions/newtab. r=home-newtab-reviewers,nbarrett
https://hg.mozilla.org/integration/autoland/rev/d36adbc21df3
Move newtab utility scripts to browser/extensions/newtab. r=home-newtab-reviewers,amy
https://hg.mozilla.org/integration/autoland/rev/d21c04034be4
Move newtab content source code and build scripts to browser/extensions/newtab. r=home-newtab-reviewers,nbarrett,thecount
https://hg.mozilla.org/integration/autoland/rev/593932e0893a
Update rejected-words.yml mapping to browser/extensions/newtab. r=linter-reviewers,sylvestre
https://hg.mozilla.org/integration/autoland/rev/3737fd75977b
Move newtab tests to browser/extensions/newtab. r=home-newtab-reviewers,omc-reviewers,frontend-codestyle-reviewers,pdahiya,thecount
https://hg.mozilla.org/integration/autoland/rev/425a43d0b287
Update a bunch of non-permalink references to browser/extensions/newtab. r=sylvestre,search-reviewers,tabbrowser-reviewers,omc-reviewers,android-reviewers,home-newtab-reviewers,frontend-codestyle-reviewers,mcheang,pdahiya,thecount,dao,pollymce
https://hg.mozilla.org/integration/autoland/rev/5e8c4adce9b0
Update mots so that New Tab module includes browser/extensions/newtab as well. r=zeid
https://hg.mozilla.org/integration/autoland/rev/0eaf0ed1dff2
Move browser/components/newtab eslintrc rules to browser/extensions/newtab. r=home-newtab-reviewers,frontend-codestyle-reviewers,Standard8,thecount

Comment 16

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e1f12f800782
https://hg.mozilla.org/mozilla-central/rev/cb931e962950
https://hg.mozilla.org/mozilla-central/rev/a440ddfb8782
https://hg.mozilla.org/mozilla-central/rev/d36adbc21df3
https://hg.mozilla.org/mozilla-central/rev/d21c04034be4
https://hg.mozilla.org/mozilla-central/rev/593932e0893a
https://hg.mozilla.org/mozilla-central/rev/3737fd75977b
https://hg.mozilla.org/mozilla-central/rev/425a43d0b287
https://hg.mozilla.org/mozilla-central/rev/5e8c4adce9b0
https://hg.mozilla.org/mozilla-central/rev/0eaf0ed1dff2