1942999 - Improve newtab linter exclusions for browser/components/newtab/data/

Status: RESOLVED FIXED

(Firefox :: New Tab Page, task)

Description

[Mark Banner (:standard8)]

(This is written for after bug 1938452 lands)

Looking at browser/extensions/newtab/data/, and the current exclusions we have for linting, I think we have it set up in an incorrect fashion.

Currently ESLint and Prettier exclude all of browser/extensions/newtab/data/, the license linter excludes browser/extensions/newtab/data/content/tippytop/images/.

However looking at the files:

• /content/activity-stream.bundle.js is a generated file, and so should be listed in Generated.txt
• content/tippytop/favicons/ and content/tippytop/images both contain third party images, so should/could be listed in ThirdPartyPaths.txt
• These are files that we write/control so could be checked under ESLint/Prettier if we remove the global exclusion for the directories:
  • content/tippytop/topsites.json
  • content/abouthomecache/*.template
  • content/newtab-render.js
  • content/assets/*

Overall, this should make it clearer as to what is actually third party and what's generated.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1942999 - Improve newtab linter exclusions for generated files and tippytop images. r?mconley!

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1942999 - Update .prettierignore exclusion lists, copying from Generated.txt and ThirdPartyPaths.txt. r?#frontend-codestyle-reviewers!

The only significant change here is the re-arrangement of where PdfJsOverridePrefs.js is ignored - moving the main ignore to Generated.txt (it was already excluded from prettier, but not other linters).
The .prettierignore additions are copy/paste updates from the other files to help keep the lists in sync.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e71cd1b0671
Improve newtab linter exclusions for generated files and tippytop images. r=mconley,frontend-codestyle-reviewers
https://hg.mozilla.org/integration/autoland/rev/6e584716a906
Update .prettierignore exclusion lists, copying from Generated.txt and ThirdPartyPaths.txt. r=frontend-codestyle-reviewers,Gijs

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/7e71cd1b0671
https://hg.mozilla.org/mozilla-central/rev/6e584716a906