1938524 - Use counter for 5-to-8-character language subtags in Intl.Locale constructor

Status: RESOLVED FIXED

(Core :: JavaScript: Internationalization API, enhancement, P2)

Description

[Henri Sivonen (:hsivonen)]

See https://github.com/unicode-org/icu4x/issues/3989 and TG2 discussion of the issue in https://docs.google.com/document/d/1tfGW373MuTuI5AJuZOCCDlMhA8Qix_vrhYxva8RUjAw/edit?tab=t.0 .

Let's add a use counter for 5-to-8-character language subtags in the Intl.Locale constructor to see if it would be sufficiently Web-compatible to start treating them as language tag syntax errors.

Comment 1

[Henri Sivonen (:hsivonen)]

The use counter should probably count usage more broadly than just in the Intl.Locale constructor. It seems to me the place for the use counter is between these two lines https://searchfox.org/mozilla-central/rev/cdfe21b20eacfaa6712dd9821d6383859ce386c6/intl/components/src/Locale.cpp#1108-1109 and to make it possible to update a use counter there, the JSContext needs to become one more argument that flows to that point from https://searchfox.org/mozilla-central/rev/cdfe21b20eacfaa6712dd9821d6383859ce386c6/js/src/builtin/intl/LanguageTag.cpp#27 .

Comment 2

[Henri Sivonen (:hsivonen)]

https://searchfox.org/mozilla-central/rev/cdfe21b20eacfaa6712dd9821d6383859ce386c6/js/src/vm/RealmFuses.cpp#83 shows a pre-existing use counter for JS.

Comment 3

[Henri Sivonen (:hsivonen)]

Attachment: Bug 1938524 - Use counter for 5-to-8-character language subtags.

Comment 4

[Henri Sivonen (:hsivonen)]

(In reply to Henri Sivonen (:hsivonen) from comment #1)

The use counter should probably count usage more broadly than just in the Intl.Locale constructor.

Or not, rather, since the main point of this is finding the cases where we currently retain and return a 5-to-8-character language instead of it being invisible if such a language failed to parse or failed to match.

Comment 5

[Henri Sivonen (:hsivonen)]

I don't know how to write a test for this, but the patch seemed to be doing thing when looking at it in a debugger.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bcea7f7aa7b1
Use counter for 5-to-8-character language subtags. r=dminor

Comment 7

[Sandor Molnar[:smolnar]]

Backed out for causing build bustages @ XPCJSRuntime.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/51d10b5db2e19bc6614930f3ea8b2181c5ff5f36

Push with failures

Failure log -> ERROR - gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:674: Unified_cpp_js_xpconnect_src0.o]

Comment 8

[Henri Sivonen (:hsivonen)]

The failure was due to a bad automerge with bug 1940109. Re-queued landing with a manual adjustment to the merged code.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f315d26db4f
Use counter for 5-to-8-character language subtags. r=dminor

Comment 10

[amarc]

https://hg.mozilla.org/mozilla-central/rev/1f315d26db4f