1940331 - Running `mach gen-use-counter-metrics` will clobber custom emails in use_counter_metrics.yaml

Status: RESOLVED INVALID

(Core :: DOM: Core & HTML, defect)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

Right now if you were to run mach gen-use-counter-metrics you'd clobber some custom emails set by Benjamin Beurdouche for MLS in Bug 1900537.

Given the header of the file is

# This file is AUTOGENERATED by usecounters.py. DO NOT EDIT.
# (instead, re-run ./mach gen-use-counter-metrics)

We probably need something better; for the patch I'm working on I've hand preserved those emails. Feels rude to just overwrite them, but at the same time, it's not an ideal workflow. If Ben doesn't really need the emails we could just use this bug to overwrite the yaml file with the generator contents.

I've marked this as Depends On Bug 1899418 which was a feature request for custom notification emails

Comment 1

[Benjamin Beurdouche [:beurdouche]]

It is fine with me if my email is clobbered, that's not a concern. By looking at the code, it looks like my counter names are not up-to-date so they might be clobbered too which is also fine.

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Alright -- when Bug 1940109 hits central I'll use this bug to land a re-run of mach gen-use-counter-metrics.

Comment 3

[Matthew Gaudet (he/him) [:mgaudet]]

Looks like this was fixed by https://hg.mozilla.org/mozilla-central/rev/1f315d26db4f