1938620 - [network-markers] Obtain the http protocol version from mResponseHead instead of mRequestHead

Status: RESOLVED FIXED

(Core :: Gecko Profiler, task, P2)

Description

[Sean Kim]

Discussion from Bug 1915717

Comment 1

[Sean Kim]

Attachment: Bug 1938620 - [network-markers] Obtain the http protocol version from mResponseHead instead of mRequestHead r=#necko,#profiler

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/68cf521768c2
[network-markers] Obtain the http protocol version from mResponseHead instead of mRequestHead r=necko-reviewers,profiler-reviewers,kershaw,julienw

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing perma bc failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/af6112a5bde36ef0fa76eaf5d5ac3750463fb3a6

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/tabbrowser/test/browser/tabs/browser_link_in_tab_title_and_url_prefilled_blank_page.js | "example.com" == "about:blank"

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_copying.js | url bar value set to example.com - Got "example.com", expected "data:text/html,(%C3%A9 %25P)

Comment 4

[Sean Kim]

(In reply to Sandor Molnar[:smolnar] from comment #3)

Backed out for causing perma bc failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/af6112a5bde36ef0fa76eaf5d5ac3750463fb3a6

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/tabbrowser/test/browser/tabs/browser_link_in_tab_title_and_url_prefilled_blank_page.js | "example.com" == "about:blank"

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_copying.js | url bar value set to example.com - Got "example.com", expected "data:text/html,(%C3%A9 %25P)

Hello, I am quite unsure if these failures are due to this patch. This is considering the fact that the patch should practically modify the same code as Bug 1915717. Thank you.

Comment 5

[Sandor Molnar[:smolnar]]

Because of some build bustages, I couldn't investigate properly the failures but that has been solved and the failures are from another bug so I have relanded your patch.
Sorry for the inconvenience.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f045584fcc5
[network-markers] Obtain the http protocol version from mResponseHead instead of mRequestHead r=necko-reviewers,profiler-reviewers,kershaw,julienw CLOSED TREE

Comment 7

[Sandor Molnar[:smolnar]]

Unfortunately, these bc failures are definitely coming from this patch.
Now that I had coverage, backfills have confirmed it so I had to back it out.

Backout link: https://hg.mozilla.org/integration/autoland/rev/a455eb54499d4d48ef7a1a510de9a5848af591e2

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/08c6b9d5d8ad
[network-markers] Obtain the http protocol version from mResponseHead instead of mRequestHead r=necko-reviewers,profiler-reviewers,kershaw,julienw

Comment 9

[amarc]

https://hg.mozilla.org/mozilla-central/rev/08c6b9d5d8ad