1938831 - Add extra test coverage verifying that userScripts behaves like an optional-only permission

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, task, P2)

Description

[Rob Wu [:robwu]]

In bug 1917000, the "userScripts" permission became an optional-only permission, which was implemented before in bug 1919323. While there is extensive test coverage for "userScripts" in optional_permissions, and extensive coverage for optional-only permissions, there are currently no unit tests that "userScripts" is really an optional-only permission.

Since the UI implementation in bug 1931548 relies on the semantics of optional-only permissions, it would be good to have additional test coverage that explicitly verifies that "userScripts" does not appear in an install prompt.

Comment 1

[Rob Wu [:robwu]]

Attachment: Bug 1938831 - Verify unsupported uses of "userScripts" permission

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6fa54856403
Verify unsupported uses of "userScripts" permission r=zombie

Comment 3

[Atila Butkovits]

Backed out for causing failures at browser_sidebar_categories.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/61fc9efd29287c5846a222dd2eb4d0a982bcb54e

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=a6fa54856403bba8f04e5d01a8940adcab0f8ac6&selectedTaskRun=Gn99-JeIQzSKQCuFFwew3w.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=488378906&repo=autoland&lineNumber=14279

Comment 4

[Rob Wu [:robwu]]

The test failed because the new test task installs an add-on, and as part of the installation the post-install notification is shown.

The browser_sidebar_categories.js is scheduled sometime after the updated test. It has certain expectations on the browser UI, expecting simulated Tab presses to focus a certain element. Because the post-install doorhanger is present, its button was focused instead of the content area. I've fixed the test by closing the post-install doorhanger.

To simulate the test failure, I appended loadTestSubscript("browser_sidebar_categories.js"); to the toolkit/mozapps/extensions/test/browser/browser_permission_prompt_userScripts.js test file and ran ./mach test toolkit/mozapps/extensions/test/browser/browser_permission_prompt_userScripts.js --headless --log-mach-verbose

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3bc4171398f9
Verify unsupported uses of "userScripts" permission r=zombie

Comment 6

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/3bc4171398f9