1931548 - Implement userScripts permission prompt (desktop)

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, task, P2)

Description

[Rob Wu [:robwu]]

The "userScripts" permission requires double confirmation as described at https://bugzilla.mozilla.org/show_bug.cgi?id=1917000#c1

Bug 1917000 will add the permission string, and bug 1931545 will add the extra notice. In this bug we should implement the permission prompt with checkbox as specified in bug 1917000 and visualized at the right of https://bugzilla.mozilla.org/show_bug.cgi?id=1917000#c2.

Comment 1

[Rob Wu [:robwu]]

Attachment: Bug 1931548 - Add double-confirmation for userScripts prompt

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b783d3def394
Add double-confirmation for userScripts prompt r=rpl

Comment 3

[amarc]

https://hg.mozilla.org/mozilla-central/rev/b783d3def394

Comment 4

[Alex Cornestean]

Verified as Fixed. Tested on the latest Nightly (135.0a1/20241223212718) under Windows 10, Ubuntu 24.04 LTS and macOS 11.3.1.

An add-on requesting the userScripts optional permission will show a prompt requiring a double confirmation and a warning message stating “Unverified scripts can pose security and privacy risks. Only run scripts from extensions or sources you trust.”.
The double confirmation consists of a checkbox stating “Allow unverified third-party scripts to access your data” which when not checked will disable the “Allow” button on the prompt and when checked will enable the “Allow” button on the prompt.

For more details, see the attached screenshots.

Comment 5

[Alex Cornestean]

Attachment: checkbox_not_checked_state.png

Comment 6

[Alex Cornestean]

Attachment: checkbox_checked_state.png