1939 - {css1} form elements not supporting borders and padding

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect, P2)

Description

[kipp]

It looks like the form element base class, nsFormControlFrame, doesn't support
borders and padding. It should.

You may need to create a pair of frames to do this: an outer frame that takes
care of the border and padding and an inner frame that doesn't.

However, if you switch over to completely windowless controls then you don't
need to bother and your paint-code can deal with it.

Comment 1

[Eric Pollmann]

*** Bug 1826 has been marked as a duplicate of this bug. ***

Comment 2

[leger]

Setting all current Open/Normal to M4.

Comment 3

[Paul MacQuiddy]

per leger, assigning QA contacts to all open bugs without QA contacts according
to list at http://bugzilla.mozilla.org/describecomponents.cgi?product=Browser

Comment 4

[Eric Pollmann]

Marking M5

Comment 5

[Eric Pollmann]

Redistributing to M8...

Comment 6

[Hixie (not reading bugmail)]

See also bug 1938, bug 1076.

Comment 7

[Eric Pollmann]

Didn't make M8

Comment 8

[Eric Pollmann]

This test case includes all of the form elements with 50px padding and a dashed
green border.

Padding and borders are not working on GFX text areas.
Padding is broken on GFX checkboxes and radio buttons (Bug 1179)
Padding is also funky (though possibly correct) on GFX selects.

Comment 9

[Kevin McCluskey (gone)]

Steve, reassigning to you for setting the padding and borders on gfx text areas

Comment 10

[buster]

reassigned to rod.  I think he already fixed this for text controls.  the bug is
for all form elements, so if text controls work I'm off the hook and rod can
pass this on to whoever is doing the remaining controls, probably himself or
kevin.

Comment 11

[rods (gone)]

Currently all form elements except selects obey border and padding.

Comment 12

[rods (gone)]

select as a combobox obeys border and padding
select as a listbox obeys border and padding but when padding is set it stops
obey the "size"

Comment 13

[Hixie (not reading bugmail)]

*** Bug 13562 has been marked as a duplicate of this bug. ***

Comment 14

[rods (gone)]

Border and padding are now working for all controls - Fixed

Comment 15

[Christine Hoffman]

Borders work on all form elements except radio buttons which have problem with
dotted and dashed borders. Opened new bug #18993 for that. Otherwise, verifying
this bug as fixed.

Comment 16

[Hixie (not reading bugmail)]

Migrating from {css1} to css1 keyword. The {css1}, {css2}, {css3} and {css-moz}
radars should now be considered deprecated in favour of keywords.
I am *really* sorry about the spam...