1939364 - almost invisible "Switch to tab" label for selected row in address bar popup on macOS

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Sören Hentzschel]

Attachment: screenshot

Bug 1916679 enabled browser.urlbar.scotchBonnet.enableOverride by default in Firefox Nightly. In combination with browser.theme.native-theme = true (also default in Firefox Nightly) and the default system theme, the label "Switch to tab" in the selected row of the address bar popup is almost invisible due to the black text color on the dark blue background.

This issue can be fixed by setting either browser.urlbar.scotchBonnet.enableOverride to false or browser.theme.native-theme to false. As far as I understand, browser.urlbar.scotchBonnet.enableOverride = true will soon be the new default in stable releases as well. I don't know the plans for browser.theme.native-theme. But of course it would be great if the default configuration of Firefox Nightly could be fixed as well.

Tested on macOS 15.2.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1916679

:daleharvey, since you are the author of the regressor, bug 1916679, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Dale Harvey (:daleharvey)]

Yup this is the same issue as 1931516, in my queue and will be addressed shortly

Comment 3

[Sören Hentzschel]

I knew about this ticket, but thought it was a different problem as there are several differences.

Bug 1931516 vs. this one

• macOS is unaffected - macOS is affected
• the light theme is afffected - the system theme is affected (the light theme is fine)
• only an issue with browser.theme.native-theme = false (default on Windows) - only an issue with browser.theme.native-theme = true (default on macOS for Nightly only)
• it's about the :hover state - it's about the selected row (:hover is fine)
• it's about the border color - it's about the text color

But if it still gets fixed as part of the same patch, I will follow bug 1931516. Thank you!

Comment 4

[Sören Hentzschel]

It's not fixed by bug 1931516.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1916679

Comment 6

[Donal Meehan [:dmeehan]]

'browser.urlbar.scotchBonnet.enableOverride' is restricted to nightly only

Comment 7

[Dale Harvey (:daleharvey)]

Attachment: Bug 1939364 - Let switchtotab button use row text color with ScotchBonnet enabled. r=dao

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dfac46d0682c
Let switchtotab button use row text color with ScotchBonnet enabled. r=dao,desktop-theme-reviewers,urlbar-reviewers

Comment 9

[Dale Harvey (:daleharvey)]

Thanks for checking that, this patch should sort it

Comment 10

[Serban Stanca [:SerbanS]]

Backed out for causing mochitests failures in browser_ext_themes_autocomplete_popup.js.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | toolkit/components/extensions/test/browser/browser_ext_themes_autocomplete_popup.js | Urlbar popup action color should be set to #5b5b66 - "rgb(0, 0, 0)" == "rgb(91, 91, 102)" -

Comment 11

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d28e2c36cf0
Backed out changeset dfac46d0682c for causing mochitests failures in browser_ext_themes_autocomplete_popup.js.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5b758322293
Let switchtotab button use row text color with ScotchBonnet enabled. r=dao,desktop-theme-reviewers,urlbar-reviewers

Comment 13

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/d5b758322293

Comment 14

[Dana Lucaci, Desktop QA]

Reproduced the issue with Firefox 135.0a1 (2024-12-28) on macOS 14.
The issue is verified fixed with Firefox 137.0a1 (20250204214027) and Firefox 136.0b1 (20250204100018) on macOS 14.