1931516 - [Windows] Switch to tab button border is not visible on hover state

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Brindusa Tot, Desktop QA]

Attachment: Screenshot 2024-11-13 234501.png

Found in

• Nightly 134.0a1

Affected versions

• Nightly 134.0a1

Tested platforms

• Affected platforms: Windows 11
• Unaffected platforms: macOS 12, Ubuntu

Tested platforms

• Have browser.urlbar.scotchBonnet.enableOverride to TRUE
• Have Firefox opened with Light Theme

Steps to reproduce

1. Open a few different websites in different tabs
2. Open a new tab and type '@' in the address bar.
3. Select 'Search Tabs' from the available options.
4. Hover over one of the results and observe the Switch to Tab button

Expected result

• Button should be easy visible, respecting the figma design

Actual result

• On the hover state, Switch to Tab button border is not visible.

Regression range

• last good: 2024-09-30
• first bad: 2024-10-01
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c6e3a646b7d4cb7a68c9114c04cb29ebd488a3f2&tochange=b9ff9648c7c589023158322886879afe99e51191
• Potentially regressed by: Bug 1918437

Additional notes

• Figma link: https://www.figma.com/design/o7FiykrKIyDBgsjEQUYDOr/Secondary-Actions-in-the-URL-Bar?node-id=1719-5368&node-type=section&t=VxCD1V7M0xttGnvG-0

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1918437

:daleharvey, since you are the author of the regressor, bug 1918437, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[James Teow [:jteow]]

Dale will investigate this bug.

Comment 4

[Dale Harvey (:daleharvey)]

ScotchBonnet isnt enabled in 134 so unaffected there

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1918437

Comment 7

[Dale Harvey (:daleharvey)]

Attachment: Bug 1931516 - Ensure visible border on hover of switchtotab button. r=dao

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9860bd082438
Ensure visible border on hover of switchtotab button. r=dao,desktop-theme-reviewers,urlbar-reviewers

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/9860bd082438

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:daleharvey, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox135 to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[Petruta Horea [:phorea], Desktop Test Engineering]

Verified as fixed using Nightly 136.0a1 (2025-01-15) under Win 11 64-bit and all Firefox default themes.