Closed Bug 1939534 Opened 1 year ago Closed 1 year ago

Separate recommendations from sponsored content in Review Checker settings

Categories

(Firefox Graveyard :: Shopping, task, P2)

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: fchasen, Assigned: rking)

References

Details

(Whiteboard: [fidefe-RCSidebar])

Attachments

(1 obsolete file)

Once the recommendations API is updated to return only recommendations or sponsored content and a browser.shopping.experience2023.recommendations.userEnabled pref added, we will need to update the UI the allow setting these preferences. This will need to apply to both the current and new shopping sidebars.

Figma shows the strings and UI, but this will be implemented in the current settings card with toggles for now: https://www.figma.com/design/6ifCrlhOYCRgUqmoTTTxsT/(Process-Archive)-Review-Checker-in-sidebar?node-id=12565-124275&node-type=frame&t=K9P5S3mpD25FymD1-0

Settings strings

Show recommended products
Other similar products with reliable reviews

Show sponsored products
Firefox doesn’t share your personal data with advertisers. Learn more

Updates to current settings

This is going require a few spread out changes to make everything work how it did before, duplicating much of https://phabricator.services.mozilla.com/D186517

  • Add a new toggle in settings.mjs
  • Make a copy of onToggleRecommendations() to handle setting the new pref. (I'd recommend we use the current on for the new pref and create a better named method like onToggleAds() for the existing)
  • Anywhere in ShoppingSidebarChild that sets or gets this.adsEnabledByUser will need a copy for this.recommendationsEnabledByUser.
  • adsEnabledByUserChanged event in ShoppingSidebarChild will need to also pass this.recommendationsEnabledByUser.
  • Shopping Container should keep track of recommendationsEnabledByUser state from the event.
  • Add a disabled_recommendations in metrics.yaml
  • surface_ads_setting_toggled should get a way to pass which setting changed, maybe type or setting (ads, recommendations)
  • Need a copy of recordUserAdsPreference

I think that should cover most of it, but will likely require updating some of the ads tests as well. There may also be some callouts that need updating.

Assignee: nobody → rking
Blocks: 1946223
No longer blocks: 1916005
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → WONTFIX
Product: Firefox → Firefox Graveyard
Attachment #9445463 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: