Closed Bug 1939621 Opened 1 year ago Closed 1 year ago

Update tests to run with ShoppingSidebar and ReviewChecker actors

Categories

(Firefox Graveyard :: Shopping, task, P3)

Tracking

(firefox136 fixed)

RESOLVED FIXED
136 Branch
Tracking Status
firefox136 --- fixed

People

(Reporter: fchasen, Assigned: fchasen)

References

Details

(Whiteboard: [fidefe-RCSidebar])

Attachments

(1 external file)

We should add a second browser toml files to run all the tests with the new Review Checker actors.

  • Test files that are testing both and should be split up.
  • Test file specific to each sidebar should only be in that toml file and renamed accordingly
  • Tests the run in about:shoppingsidebar should be run in both toml files.

A number of UI tests using about:shoppingsidebar will fail when run with the new actors, as that page now displays a valid empty state instead of an error. To make these run we will need to update the ReviewCheckerParent to not pass about:shoppingsidebar as a URL, allowing the manual setting of data the current tests are using.

We may might to follow up with some helper for the UI tests, as they all set the data similarly.

This is blocking Bug 1933539, as we need all these tests running and passing to make sure nothing breaks when splitting up the ShoppingSidebarChild.

Should also move the sidebar specific integration browser tests from the toolkit test to these browser tests.

  • Adds a browser_reviewchecker.toml to run tests specific to the Review Checker sidebar and common "about:shoppingsidebar" UI tests with the ReviewChecker actors enabled.
  • Prefaces Review Checker test filenames with browser_reviewchecker_.
  • Only runs shopping sidebar specific tests in browser.toml and prefaces those filenames with browser_shoppingsidebar_.
  • Splits out parts of test files that are specific only to one actor.
  • Renames all common tests to browser_shopping_
  • Updates ReviewCheckerParent to not return a url on about:shoppingsidebar so it is not handled valid non-product page, replicating the behavior of the current sidebar tests.
  • Adds versions of sidebar test helper methods that work with the new sidebar.
Pushed by fchasen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/33ff205b55af Update tests to run with both ShoppingSidebar and ReviewChecker actors. r=shopping-reviewers,rking,kpatenio
Regressions: 1940621
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: