1940113 - Update libvpx to new version 0b0ecb4419193ab02d16a1cbc1a6e30197be6195 from 2025-01-10 00:00:00

Status: RESOLVED FIXED

(Core :: Audio/Video, enhancement)

Description

[Update Bot]

This update covers 8 commits. Here are the overall diff statistics, and then the commit information.

---

media/libvpx/config/generic/vp8_rtcd.h | 2 +-
media/libvpx/config/generic/vp9_rtcd.h | 2 +-
media/libvpx/config/generic/vpx_dsp_rtcd.h | 2 +-
media/libvpx/config/generic/vpx_scale_rtcd.h | 2 +-
media/libvpx/config/linux/arm/vp8_rtcd.h | 2 +-
media/libvpx/config/linux/arm/vp9_rtcd.h | 2 +-
media/libvpx/config/linux/arm/vpx_dsp_rtcd.h | 2 +-
media/libvpx/config/linux/arm/vpx_scale_rtcd.h | 2 +-
media/libvpx/config/linux/arm64/vp8_rtcd.h | 2 +-
media/libvpx/config/linux/arm64/vp9_rtcd.h | 2 +-
media/libvpx/config/linux/arm64/vpx_dsp_rtcd.h | 2 +-
media/libvpx/config/linux/arm64/vpx_scale_rtcd.h | 2 +-
media/libvpx/config/linux/ia32/vp8_rtcd.h | 2 +-
media/libvpx/config/linux/ia32/vp9_rtcd.h | 2 +-
media/libvpx/config/linux/ia32/vpx_dsp_rtcd.h | 2 +-
media/libvpx/config/linux/ia32/vpx_scale_rtcd.h | 2 +-
media/libvpx/config/linux/x64/vp8_rtcd.h | 2 +-
media/libvpx/config/linux/x64/vp9_rtcd.h | 2 +-
media/libvpx/config/linux/x64/vpx_dsp_rtcd.h | 2 +-
media/libvpx/config/linux/x64/vpx_scale_rtcd.h | 2 +-
media/libvpx/config/mac/arm64/vp8_rtcd.h | 2 +-
media/libvpx/config/mac/arm64/vp9_rtcd.h | 2 +-
media/libvpx/config/mac/arm64/vpx_dsp_rtcd.h | 2 +-
media/libvpx/config/mac/arm64/vpx_scale_rtcd.h | 2 +-
media/libvpx/config/mac/ia32/vp8_rtcd.h | 2 +-
media/libvpx/config/mac/ia32/vp9_rtcd.h | 2 +-
media/libvpx/config/mac/ia32/vpx_dsp_rtcd.h | 2 +-
media/libvpx/config/mac/ia32/vpx_scale_rtcd.h | 2 +-
media/libvpx/config/mac/x64/vp8_rtcd.h | 2 +-
media/libvpx/config/mac/x64/vp9_rtcd.h | 2 +-
media/libvpx/config/mac/x64/vpx_dsp_rtcd.h | 2 +-
media/libvpx/config/mac/x64/vpx_scale_rtcd.h | 2 +-
media/libvpx/config/win/aarch64/vp8_rtcd.h | 2 +-
media/libvpx/config/win/aarch64/vp9_rtcd.h | 2 +-
media/libvpx/config/win/aarch64/vpx_dsp_rtcd.h | 2 +-
media/libvpx/config/win/aarch64/vpx_scale_rtcd.h | 2 +-
media/libvpx/config/win/ia32/vp8_rtcd.h | 2 +-
media/libvpx/config/win/ia32/vp9_rtcd.h | 2 +-
media/libvpx/config/win/ia32/vpx_dsp_rtcd.h | 2 +-
media/libvpx/config/win/ia32/vpx_scale_rtcd.h | 2 +-
media/libvpx/config/win/x64/vp8_rtcd.h | 2 +-
media/libvpx/config/win/x64/vp9_rtcd.h | 2 +-
media/libvpx/config/win/x64/vpx_dsp_rtcd.h | 2 +-
media/libvpx/config/win/x64/vpx_scale_rtcd.h | 2 +-
media/libvpx/libvpx/test/fdct8x8_test.cc | 17 +++++++++------
media/libvpx/libvpx/vp9/encoder/vp9_ratectrl.c | 25 ++++++++++++++++++++++++
media/libvpx/libvpx/vpx_dsp/vpx_dsp_common.h | 11 ++++-----
media/libvpx/moz.yaml | 4 +-
48 files changed, 86 insertions(+), 59 deletions(-)

---

0b0ecb4419193ab02d16a1cbc1a6e30197be6195 by Marco Paniconi <[e-mail]>

https://chromium.googlesource.com/webm/libvpx/+/0b0ecb4419193ab02d16a1cbc1a6e30197be6195
Authored: 2025-01-02 10:41:14 -0800
Committed: 2025-01-02 19:41:28 -0800

rtc-vp9: Fix condition for capping qp for 1 pass vbr

For 1 pass vbr no lookahead: change the low qp capping
condition for overshoot by using the worst_quality
instead of the active_worst_quality.
This makes the capping trigger more often and helps reduce
overshoot.

Change-Id: I4696cbb7b88e115177e35bb26d452e0de4691687

Files Modified:

• vp9/encoder/vp9_ratectrl.c

---

8058a0b54991257a0e1a2fcf08d993a8b70c1d3a by James Zern <[e-mail]>

https://chromium.googlesource.com/webm/libvpx/+/8058a0b54991257a0e1a2fcf08d993a8b70c1d3a
Authored: 2024-12-20 15:09:20 -0800
Committed: 2024-12-21 15:13:42 -0800

fdct8x8_test: enable optimizations w/MSVC 17.12.3+

The misoptimization issue was marked fixed as of 17.12.3. This
particular issue may have been hidden / fixed in a slightly earlier
version, as it didn't reproduce in 17.11.x, but to be safe we'll target
the official version:
https://developercommunity.visualstudio.com/t/1770-preview-1:-Misoptimization-for-AR/10369786

Change-Id: I2edabe3f4ac3666ac14d6d20c0cd20904d3c824f

Files Modified:

• test/fdct8x8_test.cc

---

6f125e95d6c8a23330e622f499a81ff8f2dbe00a by James Zern <[e-mail]>

https://chromium.googlesource.com/webm/libvpx/+/6f125e95d6c8a23330e622f499a81ff8f2dbe00a
Authored: 2024-12-20 15:30:53 -0800
Committed: 2024-12-21 15:12:38 -0800

vpx_dsp_common.h: refine clip_pixel msvc workaround

The misoptimization issue was marked fixed in 17.7:
https://developercommunity.visualstudio.com/t/Misoptimization-for-ARM64-in-VS-2022-17/10363361

Change-Id: I35e593b6420e6021f06d97b30e868dea9179b934

Files Modified:

• vpx_dsp/vpx_dsp_common.h

---

8ae5601c5f8288968a158a6fa1746a7021db505a by Marco Paniconi <[e-mail]>

https://chromium.googlesource.com/webm/libvpx/+/8ae5601c5f8288968a158a6fa1746a7021db505a
Authored: 2024-12-20 23:14:45 -0800
Committed: 2024-12-20 23:23:44 -0800

vp9: Fix assert in 1 pass vbr from encoder fuzzer

Bug: 376707227, 385170392
Change-Id: Idbae8ecb03c9162fd8e1f67e621eed1f7bde7ff8

Files Modified:

• vp9/encoder/vp9_ratectrl.c

---

61d0865fd69bb1754b15dac2a3b4d91885110e02 by James Zern <[e-mail]>

https://chromium.googlesource.com/webm/libvpx/+/61d0865fd69bb1754b15dac2a3b4d91885110e02
Authored: 2024-12-19 18:45:59 -0800
Committed: 2024-12-20 10:01:55 -0800

set_analyzer_env.sh: add float-cast-overflow w/ubsan

Tested with clang-14.

Change-Id: I396a091b7a9910fdd9cd3db7ac2e848b49d78ca5

Files Modified:

• tools/set_analyzer_env.sh

---

2c38ade434e51c6b1980a675b1c8cbee229b49ff by Marco Paniconi <[e-mail]>

https://chromium.googlesource.com/webm/libvpx/+/2c38ade434e51c6b1980a675b1c8cbee229b49ff
Authored: 2024-12-19 19:59:00 -0800
Committed: 2024-12-19 22:55:40 -0800

vp9: Fix integer overflow in ratectrl.c

Issue introduced here:
https://chromium-review.googlesource.com/c/webm/libvpx/+/6094823

Can be triggered with:
https://chromium-review.googlesource.com/c/webm/libvpx/+/6112963/2

Bug: 376707227
Change-Id: I635638114a70019d91a2ff2377382ca685adb843

Files Modified:

• vp9/encoder/vp9_ratectrl.c

---

62df56d12b1ebf1db154c3f82761747397ea2731 by Marco Paniconi <[e-mail]>

https://chromium.googlesource.com/webm/libvpx/+/62df56d12b1ebf1db154c3f82761747397ea2731
Authored: 2024-12-17 22:39:51 -0800
Committed: 2024-12-17 22:41:30 -0800

vp9 1 pass vbr: adjust qp condition on overshoot

Include the condition on top_index, and increase
qp_thresh to 32.

Change-Id: I1c9a36384c2fa596add3f750128c79fdf7d7aa81

Files Modified:

• vp9/encoder/vp9_ratectrl.c

---

a68a58b9c901a4fed408e3524bdd18c480bd5b6f by Marco Paniconi <[e-mail]>

https://chromium.googlesource.com/webm/libvpx/+/a68a58b9c901a4fed408e3524bdd18c480bd5b6f
Authored: 2024-12-13 15:31:54 -0800
Committed: 2024-12-17 11:29:28 -0800

rtc-vp9: Fix to overshoot for 1 pass VBR no lookahead

Use the buffer_level to monitor the long-term bitrate
over/undershoot and avoid going to very low QP for
overshoot. This also required adding the
vp9_update_buffer_level_preencode() for the 1 pass VBR
encoding (as is done for CBR).

This reduces the overshoot in the issue below.

Bug: 376707227
Change-Id: Idae2bb0934543063e09ba7c32f80806cc9494f13

Files Modified:

• vp9/encoder/vp9_ratectrl.c

---

Comment 1

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=cc60873bbe48bff57e6cd2ca87fa4fe6cf3c8619

Comment 2

[Update Bot]

Attachment: Bug 1940113 - Update libvpx to 0b0ecb4419193ab02d16a1cbc1a6e30197be6195

Comment 3

[Update Bot]

Attachment: Bug 1940113 - Apply mozilla patches for libvpx

Comment 4

[Update Bot]

The try push is done, we found jobs with unclassified failures.

Needs Investigation (Possible Intermittents):

• browser/components/tabbrowser/test/browser/tabs/browser_tab_manager_keyboard_access.js
  • 1 of 4 failed on the same (retriggered) task
    - test-linux1804-64-qr/opt-mochitest-browser-chrome-spi-nw-4 (QMUdAeVfSFOX3wPhrHs_Gg)

Known Issues:

• gfx/layers/apz/test/mochitest/browser.toml
  - test-linux1804-64-qr/opt-mochitest-browser-chrome-swr-a11y-checks-3 (Mw8QqykjRxyUKJ_AhWYRzw)

• gfx/layers/apz/test/mochitest/browser_test_position_sticky.js
  - test-linux1804-64-qr/opt-mochitest-browser-chrome-swr-a11y-checks-3 (Mw8QqykjRxyUKJ_AhWYRzw)

• toolkit/mozapps/extensions/test/browser/browser_html_detail_view.js
  - test-linux1804-64-qr/opt-mochitest-browser-chrome-swr-a11y-checks-7 (dGoaB63mQFaSGMbbTVk1FQ)

• toolkit/mozapps/extensions/test/browser/browser_permission_prompt_userScripts.js
  - test-linux1804-64-qr/opt-mochitest-browser-chrome-swr-a11y-checks-7 (dGoaB63mQFaSGMbbTVk1FQ)

These failures could mean that the library update changed something and caused
tests to fail. You'll need to review them yourself and decide where to go from here.

In either event, I have done all I can and you will need to take it from here. If you
don't want to land my patch, you can replicate it locally for editing with
./mach vendor media/libvpx/moz.yaml

When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef310c47bd4d
Update libvpx to 0b0ecb4419193ab02d16a1cbc1a6e30197be6195 r=chunmin
https://hg.mozilla.org/integration/autoland/rev/cc44aafd7afc
Apply mozilla patches for libvpx r=chunmin

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/ef310c47bd4d
https://hg.mozilla.org/mozilla-central/rev/cc44aafd7afc