1940889 - build failure on OpenBSD/arm64, libvpx mozilla patches not applied to 135

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Landry Breuil (:gaston)]

135.0b2 fails to build on OpenBSD/arm64:

/usr/obj/ports/firefox-135.0beta2/firefox-135.0/media/libvpx/libvpx/vpx_ports/aarch64_cpudetect.c:211:2: error: "Runtime CPU detection selected, but no CPU detection method available" "for your platform. Rerun configure with --disable-runtime-cpu-detect."
#error \
 ^
/usr/obj/ports/firefox-135.0beta2/firefox-135.0/media/libvpx/libvpx/vpx_ports/aarch64_cpudetect.c:219:13: error: call to undeclared function 'arm_get_cpu_caps'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]
    flags = arm_get_cpu_caps() & arm_cpu_env_mask();

https://phabricator.services.mozilla.com/D230146 is accepted but didn't land in 135, so the bit readding || defined(__OpenBSD) isn't present in https://searchfox.org/mozilla-beta/source/media/libvpx/libvpx/vpx_ports/aarch64_cpudetect.c#19. It's present in m-c since bug #1940113 correctly applied the patches.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1933271

:chunmin, since you are the author of the regressor, bug 1933271, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[C.M.Chang[:chunmin]]

Ooh it's my bad! I'll update the libvpx and apply our patches then uplift them to beta

Comment 3

[C.M.Chang[:chunmin]]

Attachment: Bug 1940889 - Update libvpx to 05fb2057b00d01cda1ac0d979eaf60ba87c8416e

Import latest sources by running

./mach vendor media/libvpx/moz.yaml --patch-mode=none

Comment 4

[C.M.Chang[:chunmin]]

Attachment: Bug 1940889 - Apply mozilla patches for libvpx

Apply mozilla patches by running

./mach vendor media/libvpx/moz.yaml --patch-mode=only

Comment 5

[C.M.Chang[:chunmin]]

Attachment: WIP: Bug 1940889 - Update libvpx to 05fb2057b00d01cda1ac0d979eaf60ba87c8416e

Import latest sources by running

./mach vendor media/libvpx/moz.yaml --patch-mode=none

Original Revision: https://phabricator.services.mozilla.com/D235035

Comment 6

[C.M.Chang[:chunmin]]

Attachment: WIP: Bug 1940889 - Apply mozilla patches for libvpx

Apply mozilla patches by running

./mach vendor media/libvpx/moz.yaml --patch-mode=only

Original Revision: https://phabricator.services.mozilla.com/D235036

Depends on D235068

Comment 7

[C.M.Chang[:chunmin]]

Attachment: Bug 1940889 - Update libvpx to 05fb2057b00d01cda1ac0d979eaf60ba87c8416e r=padenot

Import latest sources by running

./mach vendor media/libvpx/moz.yaml --patch-mode=none

Original Revision: https://phabricator.services.mozilla.com/D235035

Comment 8

[C.M.Chang[:chunmin]]

Attachment: Bug 1940889 - Apply mozilla patches for libvpx r=padenot

Apply mozilla patches by running

./mach vendor media/libvpx/moz.yaml --patch-mode=only

Original Revision: https://phabricator.services.mozilla.com/D235036

Depends on D235072

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/52747b70e7e5
Update libvpx to 05fb2057b00d01cda1ac0d979eaf60ba87c8416e r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/2cca63071b2e
Apply mozilla patches for libvpx r=media-playback-reviewers,padenot

Comment 10

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/52747b70e7e5
https://hg.mozilla.org/mozilla-central/rev/2cca63071b2e

Comment 11

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: video encoding may occur error for video conferencing in certain cases, build issue on OpenBSD
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: No
• Risk associated with taking this patch: low
• Explanation of risk level: it's part of the regular update process
• String changes made/needed: No
• Is Android affected?: no

Comment 12

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: video encoding may have errors during video conferencing in certain cases, build issues on openBSD
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: No
• Risk associated with taking this patch: low
• Explanation of risk level: The libvpx update is a routine we have for quite some time
• String changes made/needed: No
• Is Android affected?: no

Comment 13

[Ryan VanderMeulen [:RyanVM]]

The Beta uplift patches don't apply to the Beta branch. Please rebase and update the revisions.

Comment 14

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/6fe3aa32c068
https://hg.mozilla.org/releases/mozilla-beta/rev/4421cf3376ba