1940220 - Color settings not applied correctly in address book view

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Tobias Bossert]

Attachment: Broken address book view + color settings

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:133.0) Gecko/20100101 Firefox/133.0

Steps to reproduce:

Adjusted color scheme (Settings->Fonts->Colors), see bottom part of screenshot

Actual results:

Color scheme is not applied as as expected in address book view (see upper part of screent), renders some elements invisible.

Expected results:

All UI elements should be readable.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: Bug 1940220 - Fix the appearance of the Address Book with forced colors. r=#thunderbird-front-end-reviewers

Comment 3

[Richard Marti (:Paenglab)]

Release Note Request (optional, but appreciated)
[Why is this notable]: Behaviour change on Linux and macOS for color overrides with high contrast mode.
[Suggested wording]: Changed default behavior for color overrides with high contrast mode on macOS and Linux.
[Links (documentation, blog post, etc)]: The patch in this bug.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b80b4a203a68
Fix the appearance of the Address Book with forced colors. r=aleca

Comment 5

[Richard Marti (:Paenglab)]

Comment on attachment 9473890 [details]
Bug 1940220 - Fix the appearance of the Address Book with forced colors. r=#thunderbird-front-end-reviewers

Uplift Approval Request

• Please state case for uplift consideration and ensure bug severity is set: With forced colors bad contrast in Address Book
• User impact if declined: AB could be unreadable with forced colors.
• Is this code covered by automated tests?: No
• Has the fix been verified in Daily?: Yes
• Has the fix been verified in Beta?: N/A
• Needs manual test from QA?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Mostly CSS changes. Should be no problem.
• String changes made/needed: no

Comment 6

[Richard Marti (:Paenglab)]

Attachment: 1940220-ab-colors-ESR.patch

[User impact if declined]

• With forced colors bad contrast in Address Book

[Is this code covered by automated tests?]

• Options: No.

[Has the fix been verified in Daily? (or Beta for an ESR uplift?)]

• Yes.

[Needs manual test from QA?]

• Options: No.

[List of other uplifts needed]
-None.

[Risk to taking this patch]

• Options: Low.
• Mostly CSS changes. Should be no problem.

[String changes made/needed]

• None.

Comment 7

[Corey Bryant]

Comment on attachment 9473890 [details]
Bug 1940220 - Fix the appearance of the Address Book with forced colors. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta

Comment 8

[Corey Bryant]

Thunderbird 138.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/cfbf793d10fd

Comment 9

[Corey Bryant]

Comment on attachment 9477937 [details] [diff] [review]
1940220-ab-colors-ESR.patch

[Triage Comment]
Approved for esr128

Comment 10

[Daniel Darnell [:dandarnell]]

Thunderbird 128.10.0esr:
https://hg.mozilla.org/releases/comm-esr128/rev/fb57b123f3f3