Closed Bug 1940270 Opened 2 months ago Closed 25 days ago

[Toolbar redesign] Toolbar buttons move after swiping tabs ends in landscape

Categories

(Fenix :: Toolbar, defect)

All
Android
defect

Tracking

(firefox134 wontfix, firefox135 wontfix, firefox136 fixed)

RESOLVED FIXED
136 Branch
Tracking Status
firefox134 --- wontfix
firefox135 --- wontfix
firefox136 --- fixed

People

(Reporter: petru, Assigned: harrisono)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxdroid][group3])

Attachments

(3 files)

Steps to reproduce

  1. Run the app on a foldable or on a phone in landscape with navbar enabled
  2. Have more tabs opened
  3. Swipe the toolbar to switch between tabs

Expected behavior

The toolbars of the two tabs being switched through should have the same layout

Actual behavior

The toolbar's elements have different sizes and paddings.

Seeing there's an issue in the current release (133) also where the navbar is not available.

Whiteboard: [fxdroid][group3]

The severity field is not set for this bug.
:royang, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(royang)
Severity: -- → S4
Flags: needinfo?(royang)
Assignee: nobody → hoglesby
Status: NEW → ASSIGNED
Attachment #9461425 - Attachment description: Bug 1940270 - Fix tab preview landscape toolbar button positions → Bug 1940270 - Fix tab preview toolbar button positions
Pushed by hoglesby@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/01c867b96019 Fix tab preview toolbar button positions r=android-reviewers,Roger
Status: ASSIGNED → RESOLVED
Closed: 25 days ago
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch

The patch landed in nightly and beta is affected.
:harrisono, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox135 to wontfix.

For more information, please visit BugBot documentation.

Flags: needinfo?(hoglesby)

Because beta cut is next week, I'll let this fix ride the trains rather than uplift.

Flags: needinfo?(hoglesby)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: