1940470 - Thunderbird ESR balrog rule 17943 was removed

Status: ASSIGNED

(Thunderbird :: Build Config, defect)

Description

[Corey Bryant]

From 128.6.0esr release-balrog-scheduling-thunderbird log:

2025-01-08 14:52:47,782 - asyncio - DEBUG - Using selector: EpollSelector
2025-01-08 14:52:47,783 - balrogscript.task - INFO - actions: {'schedule'}
2025-01-08 14:52:47,789 - balrogscript.task - INFO - Servers: ['esr']
2025-01-08 14:52:47,789 - redo - DEBUG - attempt 1/5
2025-01-08 14:52:47,789 - redo - DEBUG - retry: calling <lambda>, attempt #1
2025-01-08 14:52:47,789 - balrogclient.api - DEBUG - Balrog request to https://aus4-admin.mozilla.org/api/rules/17923
2025-01-08 14:52:47,790 - balrogclient.api - DEBUG - Data sent: null
2025-01-08 14:52:47,790 - balrogclient.api - DEBUG - Refreshing, getting new token
2025-01-08 14:52:47,795 - urllib3.connectionpool - DEBUG - Starting new HTTPS connection (1): auth.mozilla.auth0.com:443
2025-01-08 14:52:47,948 - urllib3.connectionpool - DEBUG - https://auth.mozilla.auth0.com:443 "POST /oauth/token HTTP/11" 200 None
2025-01-08 14:52:47,950 - urllib3.connectionpool - DEBUG - Starting new HTTPS connection (1): aus4-admin.mozilla.org:443
2025-01-08 14:52:48,028 - urllib3.connectionpool - DEBUG - https://aus4-admin.mozilla.org:443 "GET /api/rules/17923 HTTP/11" 200 664
2025-01-08 14:52:48,029 - balrogclient.api - DEBUG - REQUEST STATS: {"timestamp": 1736347968.0290644, "method": "GET", "url": "https://aus4-admin.mozilla.org/api/rules/17923", "status_code": 200, "elapsed_secs": 0.23897194862365723}
2025-01-08 14:52:48,029 - balrogclient.api - DEBUG - Balrog request to https://aus4-admin.mozilla.org/api/rules/17923
2025-01-08 14:52:48,029 - balrogclient.api - DEBUG - Data sent: null
2025-01-08 14:52:48,030 - balrogclient.api - DEBUG - Using cached token
2025-01-08 14:52:48,030 - urllib3.connectionpool - DEBUG - Starting new HTTPS connection (1): aus4-admin.mozilla.org:443
2025-01-08 14:52:48,107 - urllib3.connectionpool - DEBUG - https://aus4-admin.mozilla.org:443 "HEAD /api/rules/17923 HTTP/11" 200 0
2025-01-08 14:52:48,107 - balrogclient.api - DEBUG - REQUEST STATS: {"timestamp": 1736347968.107332, "method": "HEAD", "url": "https://aus4-admin.mozilla.org/api/rules/17923", "status_code": 200, "elapsed_secs": 0.07731294631958008}
2025-01-08 14:52:48,107 - balrogclient.api - DEBUG - Balrog request to https://aus4-admin.mozilla.org/api/scheduled_changes/rules
2025-01-08 14:52:48,107 - balrogclient.api - DEBUG - Data sent: {"rule_id": 17923, "alias": "thunderbird-esr128", "priority": 165, "mapping": "Thunderbird-128.6.0esr-build3", "fallbackMapping": "Thunderbird-128.5.2esr-build1", "backgroundRate": 100, "update_type": "minor", "product": "Thunderbird", "version": "<129.0", "channel": "esr", "buildTarget": null, "buildID": null, "locale": null, "osVersion": null, "memory": null, "instructionSet": null, "jaws": null, "mig64": null, "distribution": null, "distVersion": null, "headerArchitecture": null, "comment": "This rule is for the upcoming ESR 128 release. I set the background rate and priority to zero to prevent interference with the existing rules.", "data_version": 39, "data_verison": 39, "change_type": "update", "when": 1736348267000}
2025-01-08 14:52:48,107 - balrogclient.api - DEBUG - Using cached token
2025-01-08 14:52:48,244 - urllib3.connectionpool - DEBUG - https://aus4-admin.mozilla.org:443 "POST /api/scheduled_changes/rules HTTP/11" 200 29
2025-01-08 14:52:48,244 - balrogclient.api - DEBUG - REQUEST STATS: {"timestamp": 1736347968.2443411, "method": "POST", "url": "https://aus4-admin.mozilla.org/api/scheduled_changes/rules", "status_code": 200, "elapsed_secs": 0.13674569129943848}
2025-01-08 14:52:48,244 - balrogclient.api - DEBUG - Balrog request to https://aus4-admin.mozilla.org/api/rules/17943
2025-01-08 14:52:48,245 - balrogclient.api - DEBUG - Data sent: null
2025-01-08 14:52:48,245 - balrogclient.api - DEBUG - Using cached token
2025-01-08 14:52:48,245 - urllib3.connectionpool - DEBUG - Starting new HTTPS connection (1): aus4-admin.mozilla.org:443
2025-01-08 14:52:48,267 - urllib3.connectionpool - DEBUG - https://aus4-admin.mozilla.org:443 "GET /api/rules/17943 HTTP/11" 404 160
2025-01-08 14:52:48,268 - balrogclient.api - ERROR - Caught HTTPError: b'{\n "detail": "Requested rule wasn't found",\n "exception": "Requested rule does not exist",\n "status": 404,\n "title": "Not Found",\n "type": "about:blank"\n}\n'
2025-01-08 14:52:48,268 - balrogclient.api - DEBUG - REQUEST STATS: {"timestamp": 1736347968.2681308, "method": "GET", "url": "https://aus4-admin.mozilla.org/api/rules/17943", "status_code": 404, "elapsed_secs": 0.023036956787109375}
2025-01-08 14:52:48,268 - redo - DEBUG - retry: Caught exception:
Traceback (most recent call last):
File "/app/lib/python3.11/site-packages/redo/init.py", line 172, in retry
return action(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^
File "/app/lib/python3.11/site-packages/balrogscript/script.py", line 136, in <lambda>
retry(lambda: scheduler.run(*args))
^^^^^^^^^^^^^^^^^^^^
File "/app/lib/python3.11/site-packages/balrogscript/submitter/cli.py", line 535, in run
data, data_version = Rule(api_root=self.api_root, auth0_secrets=self.auth0_secrets, rule_id=rule_id).get_data()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/app/lib/python3.11/site-packages/balrogclient/api.py", line 196, in get_data
resp = self.request()
^^^^^^^^^^^^^^
File "/app/lib/python3.11/site-packages/balrogclient/api.py", line 169, in request
return self.do_request(url, data, method)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/app/lib/python3.11/site-packages/balrogclient/api.py", line 186, in do_request
req.raise_for_status()
File "/app/lib/python3.11/site-packages/requests/models.py", line 1024, in raise_for_status
raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://aus4-admin.mozilla.org/api/rules/17943

Comment 1

[Corey Bryant]

Attachment: Bug 1940470 - Drop update of balrog rule 17943. r=#thunderbuild

Rule 17943 was recently removed and therefore no longer needs updating.

Comment 2

[Corey Bryant]

Comment on attachment 9446321 [details]
Bug 1940470 - Drop update of balrog rule 17943. r=#thunderbuild

[Approval Request Comment]
Regression caused by (bug #): Not caused by a bug. Caused by removal of the rule from balrog.
User impact if declined: No user impact. Build impact is the release-balrog-scheduling-thunderbird build task will continue fail.
Testing completed (on c-c, etc.): It can't be tested until it lands on comm-esr.
Risk to taking this patch (and alternatives if risky): None, this is a build change only.

Comment 3

[Corey Bryant]

Comment on attachment 9446321 [details]
Bug 1940470 - Drop update of balrog rule 17943. r=#thunderbuild

[Triage Comment]
Approved for esr128

Comment 4

[Daniel Darnell [:dandarnell]]

Thunderbird 128.7.0esr:
https://hg.mozilla.org/releases/comm-esr128/rev/9309bfdbf694