1940698 - Full-screen notification doesn't show up anymore.

Status: VERIFIED FIXED

(Firefox :: General, defect, P2)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

STR: Go to https://davidwalsh.name/demo/fullscreen.php, go fullscreen. Nothing appears.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

The reason is that:

:fullscreen:not(:root) {
  -moz-top-layer: auto !important;
  position: fixed !important;
  ...

Applies to the full-screen <browser> element, and before we were not honoring that position: fixed

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1939891

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1940698 - Use popover for fullscreen / pointer-lock warning. r=dao!

So that it shows on top of the fullscreen <browser> element. Note that
the fullscreen toggler and co doesn't need the same treatment, luckily,
because we only use it for the "firefox fullscreen" mode.

Comment 5

[Donal Meehan [:dmeehan]]

Setting Fx135 to disabled since the regressor was backed out of beta
https://bugzilla.mozilla.org/show_bug.cgi?id=1939891#c5

Comment 6

[Frederik Braun [:freddy]]

We treat non-popup full screen mode as a moderate security severity.
Given this is only rated moderate and doesn't affect anything bug Nightly builds, it's OK to land without further sec-approval.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad89e9117ae6
Use popover for fullscreen / pointer-lock warning. r=dao,desktop-theme-reviewers,tabbrowser-reviewers

Comment 8

[amarc]

https://hg.mozilla.org/mozilla-central/rev/ad89e9117ae6

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9446517 [details]
Bug 1940698 - Use popover for fullscreen / pointer-lock warning. r=dao!

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: While the main issue (the fullscreen notification not showing up) is not present in beta and release, this patch also fixes bug 1940896.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0 and bug 1940896 comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): The patch is not super complicated, and is scoped to these notifications, but it's also not as minimal...
• String changes made/needed: none
• Is Android affected?: No

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9446517 [details]
Bug 1940698 - Use popover for fullscreen / pointer-lock warning. r=dao!

Approved for 135.0b5.

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/ccee9df81027

Comment 13

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issues from comment 1 and 1940896#c0 on Windows 10x64 with Firefox 136.0a1 (2025-01-09). The fullscreen notification is not displayed when entering fs and the pointer lock message is cut off with the Alpenglow theme.
Both issues are verified fixed with Firefox 136.0a1 (20250115042832) and 135.0b5 (20250114191838 - comment 12) on Windows 10x64, macOS 12 and Ubuntu 24. The fullscreen notification and pointer lock message are correctly displayed.

Comment 14

[Pascal Chevrel:pascalc]

Comment on attachment 9446517 [details]
Bug 1940698 - Use popover for fullscreen / pointer-lock warning. r=dao!

Removing the release uplift request as 134 is not affected.