Closed Bug 1940896 Opened 2 months ago Closed 2 months ago

Permission toast message is displayed behind the address bar when using a dark theme

Categories

(Firefox :: Address Bar, defect)

Unspecified
macOS
defect

Tracking

()

RESOLVED FIXED
136 Branch
Tracking Status
firefox-esr115 --- unaffected
firefox-esr128 --- unaffected
firefox134 --- wontfix
firefox135 --- verified
firefox136 --- verified

People

(Reporter: cpeterson, Unassigned)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Attached image screenshot.png

@ Emilio, I bisected this regression to this pushlog for your address bar bug 1927111:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=13537ae67079d33202b6570bb5a61d4ee652fecb&tochange=aa2b4302bdccdbfd659158479d68c4f377237e6c

Steps to reproduce

  1. Open about:addons
  2. Enable a non-default theme, such as the "Firefox Alpenglow" theme.
  3. Open https://permission.site/
  4. Scroll down and click the "Pointer Lock" button.

Expected result

The "permission.site has control of your pointer." toast message is displayed in front of the address bar.

Actual result

The "permission.site has control of your pointer." toast message is displayed behind the address bar. See the attached screenshot.

Flags: needinfo?(emilio)

I think this is fixed by bug 1940698. Can you test the next nightly that contains that fix and let me know if it somehow doesn't? Thanks.

Depends on: 1940698
Flags: needinfo?(emilio)
Flags: needinfo?(cpeterson)

Emilio, I verified this bug is fixed in Nightly 136.0a1 (2025-01-12). Bug 1940698 comment 5 says the regressor (bug 1939891) has been backed out of Beta 135, but will it also be backed out in a dot release of Fx 134.0.x? I can reproduce this bug in Fx 134.0. Or do you consider this issue wontfix for 134?

I will leave this bug open until I verify the Beta backout fixes this issue in the next Beta 135 build and we decide whether 134 will be fixed or wontfix.

Flags: needinfo?(cpeterson) → needinfo?(emilio)

I think we could consider uplifting bug 1940698. Will add a request there.

Status: NEW → RESOLVED
Closed: 2 months ago
Duplicate of bug: 1940698
Flags: needinfo?(emilio)
Resolution: --- → DUPLICATE
No longer duplicate of bug: 1940698
Resolution: DUPLICATE → FIXED
Target Milestone: --- → 136 Branch

This was verified with Firefox 135.0b5 in 1940698#c13.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: