1946458 - New Tab wallpaper thumbnails are referenced by about:welcome

Status: RESOLVED FIXED

(Firefox :: Messaging System, task, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

It looks like we statically reference New Tab's wallpaper thumbnails from about:welcome: https://searchfox.org/mozilla-central/rev/d1fbe983fb7720f0a4aca0e748817af11c1a374e/browser/components/aboutwelcome/content-src/aboutwelcome.scss#1683-1733

If both about:welcome and about:newtab need to know about wallpapers, then we should make it so that New Tab exposes some stable method for about:welcome to get that information, or we should maybe factor our the wallpaper logic into a shared module that lives outside of browser/extensions/newtab. I'm not entirely sure which is best at the moment.

Comment 1

[Punam Dahiya [:pdahiya]]

I think with wallpaper graduated to newtab, simplest will be to remove custom logic added with https://phabricator.services.mozilla.com/D205658 to support showing wallpapers in a spotlight ( as desired in Bug 1916836) . I will submit a patch.

Comment 2

[Punam Dahiya [:pdahiya]]

Attachment: Bug 1946458 - Remove wallpaper select custom handling in aboutwelcome bundle

Comment 3

[Punam Dahiya [:pdahiya]]

Marking fix of this bug blocking Bug 1940816 as wallpaper chrome path in aboutwelcome.scss causes browser_parsable_css.js to complain with chrome://newtab mappings

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f3a00e2cc95a
Remove wallpaper select custom handling in aboutwelcome bundle r=amy,omc-reviewers,emcminn,fluent-reviewers,bolsson

Comment 5

[amarc]

https://hg.mozilla.org/mozilla-central/rev/f3a00e2cc95a