Closed Bug 1941047 Opened 1 month ago Closed 22 days ago

Add new probe for tracking whenever RC is loaded/unloaded in the sidebar

Categories

(Firefox :: Shopping, task, P2)

task
Points:
3

Tracking

()

RESOLVED FIXED
136 Branch
Tracking Status
firefox136 --- fixed

People

(Reporter: kpatenio, Assigned: kpatenio)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-RCSidebar])

Attachments

(1 file)

We have existing metrics in place for default sidebar tools recording whenever a tool is loaded or unloaded. We have yet to implement a similar measurement for Review Checker. It would be nice to have it so that the sidebar team can accurately track overall sidebar usage.

  1. Rather than using our own shopping/metrics.yaml, I think we'll want to use the sidebar one instead. browser-sidebar is where we record the load/unload events. It would be more straightforward to use sidebar metric file, but let's confirm with the sidebar team if that's a correct assumption.
  2. Plus, we'll need to update some keys / details to match Review Checker:
    type: event
    description: >
      Review Checker sidebar panel was toggled open/close.
    bugs:
      - [TODO: this bug ID]
    data_reviews:
      - [TODO: phab revision link]
    data_sensitivity:
      - interaction
    expires: 147
    notification_emails:
      - [TODO: insert contact email]
    send_in_pings:
      - events
    extra_keys:
      opened:
        type: boolean
        description: New/current state of sidebar is open.

We will want to add a version extra key as well. See https://bugzilla.mozilla.org/show_bug.cgi?id=1940163.

  1. The patch should also have tests. I see that there are tests for the sidebar sidebar_toggle events in browser_glean_sidebar.js. If we're okay with making changes in the sidebar code, let's add a test case for Review Checker in the test file.
Severity: -- → N/A
Priority: -- → P3
Whiteboard: [fidefe-RCSidebar]
Priority: P3 → P2
Points: --- → 3
Assignee: nobody → kpatenio
Status: NEW → ASSIGNED
Attachment #9460816 - Attachment description: WIP: Bug 1941047 - Add new probe for tracking whenever RC is loaded/unloaded in the sidebar. r=#shopping-reviewers! → Bug 1941047 - Add new probe for tracking whenever RC is loaded/unloaded in the sidebar. r=#shopping-reviewers!
Pushed by kpatenio@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c57dcd748660 Add new probe for tracking whenever RC is loaded/unloaded in the sidebar. r=sidebar-reviewers,shopping-reviewers,rking
Status: ASSIGNED → RESOLVED
Closed: 22 days ago
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
Regressions: 1943768
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: