1941134 - Crash in [@ mozilla::ErrorLoadingSheet] from designmode.css

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Andrew McCreight [:mccr8]]

Crash report: https://crash-stats.mozilla.org/report/index/36d84ab5-b7ac-4157-a099-351c40250111

MOZ_CRASH Reason:

LoadSheetSync failed with error 80520012 loading built-in stylesheet 'resource://gre/res/designmode.css'

Top 10 frames:

0  xul.dll  MOZ_Crash(char const*, int, char const*)  mfbt/Assertions.h:317
0  xul.dll  mozilla::ErrorLoadingSheet(nsIURI*, char const*, mozilla::css::FailureAction)  layout/style/GlobalStyleSheetCache.cpp:510
1  xul.dll  mozilla::GlobalStyleSheetCache::LoadSheet(nsIURI*, mozilla::css::SheetParsing...  layout/style/GlobalStyleSheetCache.cpp:527
2  xul.dll  mozilla::GlobalStyleSheetCache::LoadSheetURL(char const*, mozilla::css::Sheet...  layout/style/GlobalStyleSheetCache.cpp:481
3  xul.dll  mozilla::GlobalStyleSheetCache::DesignModeSheet()  layout/style/UserAgentStyleSheetList.h:25
4  xul.dll  mozilla::GlobalStyleSheetCache::InitSharedSheetsInParent()  layout/style/UserAgentStyleSheetList.h:25
5  xul.dll  mozilla::GlobalStyleSheetCache::GlobalStyleSheetCache()  layout/style/GlobalStyleSheetCache.cpp:244
5  xul.dll  mozilla::GlobalStyleSheetCache::Singleton()  layout/style/GlobalStyleSheetCache.cpp:431
6  xul.dll  mozilla::dom::Document::FillStyleSetUserAndUASheets()  dom/base/Document.cpp:3226
6  xul.dll  mozilla::dom::Document::FillStyleSet()  dom/base/Document.cpp:3283

See bug 1681745 comment 19 from gsvelto:

There is a very large spike here of Windows 10 users with the following crash reason:

LoadSheetSync failed with error 80520012 loading built-in stylesheet 'resource://gre/res/designmode.css'

80520012 is NS_ERROR_FILE_NOT_FOUND and it's a startup crash, so the users are livid in the comments. The crash seems to be affecting only users on version 133.0.3. There's only a handful of crashes on file for version 134.0 and only one of them is for Windows 10 but the cause is different, so this might not be affecting people on 134.0. However I wonder if those experiencing the crash can upgrade or are stuck with the broken version.

Comment 1

[Andrew McCreight [:mccr8]]

There are a number of comments talking about how Firefox wouldn't start after it upgraded.

Ryanvm mentioned bug 1388910, which deleted designmode.css. Maybe these users are ending up with Firefox running with an old executable and a new omnija.

Most crashes don't have a telemetry environment, but I found one that does where displayVersion is 134.0 but platformVersion and version are 133.0.3. The former is from the omnija and the latter from native code, so that would be consistent with this theory. However, I found another crash with a telemetry environment where they are all consistent. Very few have one, and I'm not sure how it gets populated if you crash immediately so take these both with a gain of salt.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1388910

:emilio, since you are the author of the regressor, bug 1388910, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Gabriele Svelto [:gsvelto]]

I opened a whole bunch of crashes and all of those that I found with a telemetry environment had a different version and displayVersion. Usually 133.0.3 and 134.0. However I also found this crash which is the same problem but version is 132.0.1 and displayVersion is 134.0. More importantly macOS is clearly affected and there's a handful of Linux crashes too (like this one). The Linux crashes have the Vendor annotation set to Mozilla so it's our own distribution. How could we get in this situation on three different platforms? Also, how come this happens even when upgrading from older versions to 134.0? Did we get something fundamentally wrong in the updater? It looks like we have replaced the omni.ja file with a newer version but none of the other bits of the installation.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Yeah so this clearly isn't really a regression from bug 1388910, but if needed we could stash an empty designmode.css if we need more time to diagnose this. This probably exposed a pre-existing issue with the updated where we run an older build with a newer omni.ja.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1941134 - Wallpaper: Add designmode.css again to the bundle. r=jesup

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de9228ff245d
Wallpaper: Add designmode.css again to the bundle. r=jesup

Comment 7

[amarc]

https://hg.mozilla.org/mozilla-central/rev/de9228ff245d

Comment 8

[Yannis Juglaret [:yannis]]

Even though these issues have been around for a very long time (e.g. bug 1014666), mismatched versions after updating are still a blind spot in updater & crash telemetry as of today as far as I understand. Usually this translates into a XULRunner platform version error dialog, which does not cause a crash and so we don't get any feedback; yet that leaves Firefox just as unusable as a startup crash. Occasionally these issues cause actual crashes, like in bug 1909898 and this bug. See bug 1917317 for a recent discussion on this topic.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9459044 [details]
Bug 1941134 - Wallpaper: Add designmode.css again to the bundle. r=jesup

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Papers over startup crash
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Adds an empty file to the omni.ja
• String changes made/needed: none
• Is Android affected?: Unknown

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/71e39ff19c29

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/77c3461c8905

Comment 12

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Tried reproducing the crash on Windows 10 / macOS 15.2 with Firefox 132.0.2, 133.0.3 and 134.0, each standalone installed and updated between them by paveover (updates were disabled) but I didn't encounter any. We'll keep an eye out for this and report if any of our team colleagues will encounter it.