1941269 - preview popup doesn't show the value of the hovered token

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce

1. Open the console
2. Evaluate the following

function a(value) {
  b(value).catch(console.error);
  debugger;
};

function b() {
  return new Promise(() => {});
}

a("foo")

3. The debugger should pause, hover value on line 2

Expected results

The preview popup content is "foo"

Actual results

The popup shows content for the catch function

---

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

(updated STR with simpler steps)

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

this doesn't happen with devtools.debugger.features.codemirror-next set to false.
Reverting Bug 1874656 does fix the issue

Comment 3

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1874656

:bomsy, since you are the author of the regressor, bug 1874656, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 4

[Hubert Boma Manilla (:bomsy)]

Thanks for catching! will take a look.

Comment 5

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1941269 - [devtools] Fix matching the wrong value in the member expression r=#devtools

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01fa330d2ecc
[devtools] Fix matching the wrong value in the member expression r=devtools-reviewers,nchevobbe

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/01fa330d2ecc

Comment 8

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:bomsy, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox135 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Hubert Boma Manilla (:bomsy)]

Comment on attachment 9459089 [details]
Bug 1941269 - [devtools] Fix matching the wrong value in the member expression r=#devtools

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: User might see wrong values for certain tooltip previews in the debugger
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small javascript code change.
• String changes made/needed:
• Is Android affected?: No

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9459089 [details]
Bug 1941269 - [devtools] Fix matching the wrong value in the member expression r=#devtools

Approved for 135.0b8.

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/37a89bbf34f8