1941344 - Hide vertical tabs close button for pinned tabs and unpinned selected tab

Status: RESOLVED FIXED

(Firefox :: Sidebar, task, P1)

Description

[Kelly Cochrane [:kcochrane]]

As pinned tabs aren't closed often, UX has requested that we not show the new close button (added in bug 1933479) on vertical pinned tabs when the sidebar is collapsed.

Comment 1

[Yulia Popova]

• In addition, could we reduce the size of the circle to 15 px.
• Move the button a bit up, so that the button covers less of the tab. We hope it will help us to decrees the amount of misclicks.
  Currently, in Nightly, the button appears lower and, therefore, more on top of the tab. I understand the rationale for the current positioning—it prevents the close button of the first tab from being covered by the toolbar.
  We had the same issue with the shadow of the first selected tab—the shadow was getting cut off by the toolbar. This is the reason why we moved the first tab slightly down. However, this was a temporary solution, and we wanted to revisit this issue to realign the position of the first tab with the content of the page.

Comment 2

[Yulia Popova]

Attachment: Screenshot 2025-01-14 at 19.07.22.png

Comment 3

[Yulia Popova]

After observing confusion caused by the presence of two close buttons—one on the selected tab and another on the tab currently being hovered over—we decided to remove the close button from the selected tab.
I have confirmed with Anna from the Accessibility Team that the absence of the close button on the selected tab won't be a blocker.

Comment 4

[Sarah Clements [:sclements]]

Attachment: Bug 1941344 - changes to vertical close tabs button r=#sidebar-reviewers

• Hide close button for selected and pinned tabs
• Adjust positioning for close button in collapsed state

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/955bfab49273
changes to vertical close tabs button r=desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,dao,jsudiaman

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/955bfab49273

Comment 7

[Matt Boris [:mboris]]

It seems like the close button is for sure hidden on pinned tabs, but now, if you click in the spot where the close button used to be, the pinned tab still closes. Even the "Close tab" tooltip appears if you hover over where it used to be. This was quite confusing the first time it happened to me.

Please let me know if you need anything from me or if you cannot reproduce.

Comment 8

[Kelly Cochrane [:kcochrane]]

Not sure why I was NIed here, I wasn't the author of this patch

Comment 9

[Matt Boris [:mboris]]

Just figured the reporter may be interested in validating this. Sorry about that.

Comment 10

[Sarah Clements [:sclements]]

(In reply to Matt Boris :mboris from comment #7)

It seems like the close button is for sure hidden on pinned tabs, but now, if you click in the spot where the close button used to be, the pinned tab still closes. Even the "Close tab" tooltip appears if you hover over where it used to be. This was quite confusing the first time it happened to me.

Please let me know if you need anything from me or if you cannot reproduce.

Thanks, someone else filed bug 1946589 for this so it will be addressed.