1946589 - Vertical pinned tabs can be closed by clicking the top left corner

Status: VERIFIED FIXED

(Firefox :: Sidebar, defect, P1)

Description

[Robin Steuber (she/her) [:bytesized]]

I keep accidentally closing my pinned tabs and I finally realized that even though there is no X icon on hover for the pinned tabs, they still close when you click there.

Comment 1

[Robin Steuber (she/her) [:bytesized]]

I took a video of the problem happening in a clean profile.

Comment 2

[Sarah Clements [:sclements]]

Thanks for the bug, I can reproduce it.

Comment 3

[Sarah Clements [:sclements]]

[Tracking Requested - why for this release]: It'd like to get this uplifted since it didn't get addressed properly in bug 1941344.

Comment 4

[Sarah Clements [:sclements]]

Attachment: Bug 1946589 - Vertical pinned tabs should not close when clicking top corner r=#sidebar-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7f54779fd0a
Vertical pinned tabs should not close when clicking top corner r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,dao,kcochrane

Comment 6

[amarc]

https://hg.mozilla.org/mozilla-central/rev/e7f54779fd0a

Comment 7

[Sarah Clements [:sclements]]

Comment on attachment 9464712 [details]
Bug 1946589 - Vertical pinned tabs should not close when clicking top corner r=#sidebar-reviewers

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Users may accidentally close pinned tabs in vertical tabs mode.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See description.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very small CSS change that is contained to vertical tabs, and which has test coverage.
• String changes made/needed: N/A
• Is Android affected?: No

Comment 8

[Peter Magyari (Desktop QA)]

Verified fixed using Nightly 137.0a1 (20250211090130) on MacOS 14, Windows 10 and Ubuntu 24.

Comment 9

[Donal Meehan [:dmeehan]]

Comment on attachment 9464712 [details]
Bug 1946589 - Vertical pinned tabs should not close when clicking top corner r=#sidebar-reviewers

Approved for 136.0b5

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/f481f349f99e

Comment 11

[Peter Magyari (Desktop QA)]

Verified fixed on Beta 136.0b5 (20250211164429) build downloaded from Comment 10.