Closed Bug 1941404 Opened 1 year ago Closed 2 months ago

Allow to adjust properties of the window geometry ("x", "y", "width", and "height") individually

Categories

(Remote Protocol :: Agent, task, P3)

Product:
Remote Protocol
Component:
Agent
Type:
task

Tracking

(firefox153 fixed)

Status:
RESOLVED FIXED
Milestone:
153 Branch
Tracking Flags:
Tracking Status
firefox153 --- fixed

People

(Reporter: whimboo, Assigned: khalid.alhaddad98, Mentored)

References

(
URL
)

Details

(Whiteboard: [webdriver:m20][webdriver:external][lang=py][lang=js][wptsync upstream][webdriver:relnote])

Attachments

(1 file)

Bug 1941404 - Allow to adjust properties of the window geometry ("x","y","width", and "height") individually. r?whimboo
48 bytes, text/x-phabricator-request
Details | Review

The PR https://github.com/w3c/webdriver/pull/1830/files on the WebDriver repository changed the way how the Set Window Rect command works. Formerly it was only possible to change the window position when providing both x and y, and changing the dimensions by providing both the width and height. This is now no longer required and it is enough to specify a single value (for the other the current value is used) or even none (nothing will change).

No current browser supports that yet, so we could get started to create those tests once the patch on bug 1855028 was landed - it sets that behavior for not only BiDi but also classic.

Mentor: hskupin
Priority: -- → P3
Whiteboard: [lang=py]

Given that the adjustWindowGeometry() helper is now in the shared WindowManager module a change would affect both of our Marionette and WebDriver BiDi implementations. As such the following work is needed here:

  1. Update the code of the adjustWindowGeometry() method to allow setting the properties individually
  2. Update and enhance the WebDriver tests for Marionette.
  3. Do the same additions / changes for WebDriver BiDi.
Component: Marionette → Agent
Summary: [wdspec] Enhance tests for "Set Window Rect" to allow setting "x", "y", "width", and "height" individually → Allow to adjust properties of the window geometry ("x", "y", "width", and "height") individually

We will get updated Webdriver classic tests via bug 1975143.

Depends on: 1975143
Whiteboard: [lang=py] → [lang=py][lang=js]
Assignee: nobody → khalid.alhaddad98
Pushed by hskupin@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/2597d812efe0 https://hg.mozilla.org/integration/autoland/rev/ffabae6ff382 Allow to adjust properties of the window geometry ("x","y","width", and "height") individually. r=whimboo

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/60176 for changes under testing/web-platform/tests

Whiteboard: [lang=py][lang=js] → [lang=py][lang=js], [wptsync upstream]

https://hg.mozilla.org/mozilla-central/rev/ffabae6ff382

Status: NEW → RESOLVED
Closed: 2 months ago
status-firefox153: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch

Upstream PR merged by moz-wptsync-bot

Great work Khalid! Let me know if you are interested in something else and need help with finding a new challenging bug. Thanks!

Whiteboard: [lang=py][lang=js], [wptsync upstream] → [webdriver:m20][webdriver:external][lang=py][lang=js][wptsync upstream]

Yes, I would like to work on a new bug.

Whiteboard: [webdriver:m20][webdriver:external][lang=py][lang=js][wptsync upstream] → [webdriver:m20][webdriver:external][lang=py][lang=js][wptsync upstream][webdriver:relnote]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: