Closed Bug 1975143 Opened 2 months ago Closed 2 months ago

[wpt-sync] Sync PR 53421 - [WebDriver: Set Window Rect] Make best-effort with partial input according to latest spec

Categories

(Remote Protocol :: Marionette, task, P4)

task

Tracking

(firefox142 fixed)

RESOLVED FIXED
142 Branch
Tracking Status
firefox142 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 53421 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/53421
Details from upstream follow.

Euclid Ye <yezhizhenjiakang@gmail.com> wrote:

[WebDriver: Set Window Rect] Make best-effort with partial input according to latest spec

The spec was changed in https://github.com/w3c/webdriver/pull/1830 to allow partial parameter and change with best-effort. This makes some test assertion out-dated.

This commit removes those out-dated test and move them to a new function test_partial_input to match the new expectation.

Fixes: https://github.com/web-platform-tests/wpt/issues/53409
The change is recommended in https://github.com/w3c/webdriver/issues/1906#issuecomment-3008542906

Component: web-platform-tests → Marionette
Product: Testing → Remote Protocol

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 71 subtests

Status Summary

Firefox

OK : 1
PASS: 63[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt, GitHub] 65[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt]
FAIL: 6[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 8[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt, GitHub]

Chrome

OK : 1
PASS: 62
FAIL: 9

Safari

OK : 1
PASS: 62
FAIL: 9

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /webdriver/tests/classic/set_window_rect/set.py [wpt.fyi]: OK [Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: OK, Safari: OK)
    • test_partial_input[rect0]: FAIL (Chrome: FAIL, Safari: FAIL)
    • test_partial_input[rect1]: FAIL (Chrome: FAIL, Safari: FAIL)
    • test_partial_input[rect2]: FAIL [Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt, GitHub], PASS [Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] (Chrome: FAIL, Safari: FAIL)
    • test_partial_input[rect3]: FAIL [Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt, GitHub], PASS [Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] (Chrome: FAIL, Safari: FAIL)
    • test_partial_input[rect4]: FAIL (Chrome: FAIL, Safari: FAIL)
    • test_partial_input[rect5]: FAIL (Chrome: FAIL, Safari: FAIL)
    • test_partial_input[rect6]: FAIL (Chrome: FAIL, Safari: FAIL)
    • test_partial_input[rect7]: FAIL (Chrome: FAIL, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

  • /webdriver/tests/classic/set_window_rect/set.py [wpt.fyi]: OK [Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt, GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-isolated-process-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: OK, Safari: OK)
Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/2b102b4bebad https://hg.mozilla.org/integration/autoland/rev/a71b0d9c5466 [wpt PR 53421] - [WebDriver: Set Window Rect] Make best-effort with partial input according to latest spec, a=testonly
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 142 Branch
You need to log in before you can comment on or make changes to this bug.