1941471 - Parallel UI for using new folder objects

Status: ASSIGNED

(Thunderbird :: Folder and Message Lists, task)

Description

[Geoff Lankow (:darktrojan)]

To use the new database, we're going to have to make a few major changes and many minor changes to the mail tab UI. In this bug I'll create a second version of about:3pane (and maybe about:message) so that we can use both implementations in parallel until we're happy with the new code.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1941471 - Create an adapter for getting messages from a live view to the message list. r=#thunderbird-reviewers

This is the very start of this class which power the message list. With this patch we get messages
from the back end and display them in descending date order. Subsequent patches will add sorting
by other fields and in ascending order as required.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1941471 - Make the live view data adapter live. r=#thunderbird-reviewers

This patch adds notification abilities to the live view and handles messages added to or removed
from the database.

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1941471 - Enable sorting of the message list by ascending date order. r=#thunderbird-reviewers

This patch has the beginnings of the sort mechanism for live views.

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1941471 - Enable sorting of the message list by subject. r=#thunderbird-reviewers

This is the first textual property we'll be able to sort by.

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1941471 - Implement sender column formatting and sorting. r=#thunderbird-back-end-reviewers

This adds a SQL function for formatting addresses based on the existing preferences for doing so.
I've implemented it in this way so that SQLite can handle most of the sorting (except when new
messages are added) and we don't have to think about it, because it's just the same as any other
property. It's currently quite slow across a large number of messages but that's mostly due to the
header parsing being implemented in JS. We should fix that.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/478eb4235266
Create an adapter for getting messages from a live view to the message list. r=mkmelin
https://hg.mozilla.org/comm-central/rev/808066c0ebd1
Make the live view data adapter live. r=mkmelin
https://hg.mozilla.org/comm-central/rev/08b235cc8863
Enable sorting of the message list by ascending date order. r=mkmelin
https://hg.mozilla.org/comm-central/rev/7ba87e82d585
Enable sorting of the message list by subject. r=mkmelin
https://hg.mozilla.org/comm-central/rev/1f9b324808fe
Implement sender column formatting and sorting. r=mkmelin

Comment 7

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1941471 - Split message flags into columns in LiveViewDataAdapter.js. r=#thunderbird-reviewers

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/698a72b7ceb3
Split message flags into columns in LiveViewDataAdapter.js. r=mkmelin

Comment 9

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1941471 - Add virtual folder filter to LiveViews. r=#thunderbird-back-end-reviewers

This adds the SQL for using the virtualFolder_folders table, and a mechanism for (in future)
updating the filter when the virtual folder changes. This filter doesn't yet handle virtual folders
that display a subset of the messages (i.e. a saved search).

Comment 10

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1941471 - Add recipients to live views. r=#thunderbird-reviewers

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a19d2bdfac32
Add virtual folder filter to LiveViews. r=BenC
https://hg.mozilla.org/comm-central/rev/9ef72a3e1dc4
Add recipients to live views. r=BenC

Comment 12

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1941471 - Panorama view as a separate document.

Comment 13

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1941471 - Add live view filter for conversations. r=aleca

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6d5c3438cc6d
Panorama view as a separate document. r=aleca

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/63be1fcf8fc3
Add live view filter for conversations. r=aleca

Comment 16

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1941471 - Add message thread properties to live view JS objects. r=aleca,freaktechnik

Comment 17

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1941471 - Make live views that do threads only. r=aleca,freaktechnik

Comment 18

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1941471 - Handle text encoding properly when making LiveView JS objects. r=aleca

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e72a6c3b6519
Handle text encoding properly when making LiveView JS objects. r=aleca

Comment 20

[Geoff Lankow (:darktrojan)]

Attachment: WIP: Bug 1941471 - Add a function to get the messages in a thread from a LiveView. r=#thunderbird-back-end-reviewers

Comment 21

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1941471 - Add threaded and grouped views to the Panorama UI. r=#thunderbird-back-end-reviewers!,freaktechnik

Comment 22

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1941471 - Make panorama views load async. r=BenC!,freaktechnik!

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0bccdf3167b8
Add threaded and grouped views to the Panorama UI. r=freaktechnik,mkmelin

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/638177e0cd04
follow-up - Fix an assertion failure in a test. rs=bustage-fix

Comment 25

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1941471 - Use xpcom objects instead of JS objects for live views. r=#thunderbird-back-end-reviewers

Unfortunately if the database querying is going to be async (and it should be) there are problems
with our "create plain JS objects and throw them at the front end" approach. It's possible these
problems could be resolved, but for now at least it's easier if we just use read-only XPCOM objects.

Comment 26

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1941471 - Improve the tags matching SQLite function. r=#thunderbird-reviewers

This should improve the performance of the function by running through the haystack only once
looking for the needle, rather than splitting the haystack up and checking if one of the tokens is
the needle.

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d03967f4602d
Make panorama views load async. r=BenC,freaktechnik

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b7414bbfe5cc
Improve the tags matching SQLite function. r=mkmelin

Comment 29

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1941471 - Pass messages to JS incrementally, and simplify LiveViewDataAdapter. r=BenC

When selecting messages, the JS objects will be passed to the front end as soon as there is enough
to fill the screen. This dramatically speeds up perceived loading time.

I've broken a few things in the process, but they are not the most important right now.

Comment 30

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1941471 - Reimplement adding and removing messages in LiveViewDataAdapter. r=#thunderbird-reviewers

This patch implements what happens when a message is added to, or removed from, the database and
it is relevant to an active live view. New messages should be added to the appropriate thread or
group, if any.

It doesn't cover ordering the messages within a thread or group, nor reordering the threads or groups.

Comment 31

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5906a999d0b9
Pass messages to JS incrementally, and simplify LiveViewDataAdapter. r=BenC