1941625 - Implement sidebar right-click menu

Status: RESOLVED FIXED

(Firefox :: Sidebar, enhancement, P2)

Description

[Ania]

PRD
As a horizontal tabs user, I want to quickly set up my sidebar experience, even in cases when I cannot discover the Customize sidebar gear icon.

Acceptance criteria
Acceptance criteria
I can access the following right-click menu options upon the right-click on the sidebar:
Hide Sidebar
The option hides the sidebar launcher (and any open panels), but keeps the sidebar button present in the toolbar.
Customize Sidebar
The option opens the Customize sidebar panel.
Turn on Vertical Tabs
The option switches tab orientation to vertical. If a user has a show/hide sidebar button setting in the horizontal tabs mode, moving to vertical tabs resets their choice to the default vertical tabs behavior.

Comment 1

[Ania]

Katie, can you please confirm if the strings look good to you?
I'm wondering if Customize sidebar could be collapsed to Customize without losing the comprehension?

Comment 2

[Ania]

Attachment: Context Menu MacOS.png

Comment 3

[Ania]

Attachment: sidebar right click

Comment 4

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Bug 1941625 - Add context menu items for sidebar main r=#sidebar-reviewers

On right clicking the sidebar main element when vertical tabs are disabled,
show options for hiding the sidebar, customizing the sidebar and turning on
vertical tabs.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/650ff35a3ff0
Add context menu items for sidebar main r=sidebar-reviewers,fluent-reviewers,bolsson,kcochrane

Comment 6

[Cosmin Sabou [:CosminS]]

Backed out changeset 650ff35a3ff0 (Bug 1941625) for causing browser_sidebar related failures.

Push with failures

Failure logs:

• https://treeherder.mozilla.org/logviewer?job_id=495025877&repo=autoland
• https://treeherder.mozilla.org/logviewer?job_id=495028665&repo=autoland
• https://treeherder.mozilla.org/logviewer?job_id=495028401&repo=autoland

Backout link

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd70f1bddf5b
Add context menu items for sidebar main r=sidebar-reviewers,fluent-reviewers,bolsson,kcochrane

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/bd70f1bddf5b