1938249 - [Horizontal tabs mode] Sidebar button should show/hide the sidebar

Status: VERIFIED FIXED

(Firefox :: Sidebar, enhancement, P1)

Description

[Ania]

Current behavior in horizontal tabs mode:

1. Clicking on the collapsed sidebar expands it to display icons with labels.
2. Clicking on the expanded sidebar collapses it back to icon-only view.

Amended desired behavior in horizontal tabs mode:

1. Expanded sidebar state is no longer available in horizontal tabs mode.

2. Clicking on the sidebar button hides the collapsed sidebar or returns it into view, if it was already hidden.
   1a. If a panel was open when the collapsed sidebar was hidden, the sidebar returns into view with the same panel open.

3. The sidebar button tooltip in the horizontal tabs mode is:
   Show sidebar (%platform-specific-keyboard shortcut%)
   Hide sidebar (%platform-specific-keyboard shortcut%)

Tagging Katie here to review the strings and check if they need any updates.

Comment 1

[Sarah Clements [:sclements]]

A note that Kelly's patch for expand-on-hover in bug 1930201 removes the auto-collapsing behavior.

Comment 2

[Sarah Clements [:sclements]]

Nikki, there's some changes to the Customize Sidebar settings in bug 1939917 that would probably make sense to do in this patch. What do you think?

Sidebar settings Controls: Checkboxes
*Options for horizontal tabs mode:
Show sidebar
Show sidebar on the right

*Options for vertical tabs mode:
Expand sidebar on hover
Show sidebar on the right

I think as part of this change, if a user switches from "expand on hover" setting to "show sidebar" then vertical tabs should also revert to horizontal tabs to avoid the issue now where a user can get into a state of having the sidebar hidden and no tabs.

Comment 3

[Nikki Sharpley (:nikkis) (she/her)]

Agreed! I'll include those changes in this bug.

I think as part of this change, if a user switches from "expand on hover" setting to "show sidebar" then vertical tabs should also revert to horizontal tabs to avoid the issue now where a user can get into a state of having the sidebar hidden and no tabs.

I think that makes sense.

Comment 4

[klower]

Just confirming that, for horizontal tab users, the strings that Ania noted are good to go!

The sidebar button tooltip in the horizontal tabs mode is:
Show sidebar (%platform-specific-keyboard shortcut%)
Hide sidebar (%platform-specific-keyboard shortcut%)

Comment 5

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Bug 1938249 - Disable expanded sidebar behaviour for horizontal tabs mode r=#sidebar-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/125d12cc3cdb
Disable expanded sidebar behaviour for horizontal tabs mode r=sidebar-reviewers,desktop-theme-reviewers,dao,jsudiaman,kcochrane

Comment 7

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_sidebar_keys.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/4aaa5b3d2ce735ac377e027d5f5826d0767c4bb5

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/base/content/test/sidebar/browser_sidebar_keys.js | Sidebar widget background should appear unchecked - 0.30000001192092896 == 0

TEST-PASS | browser/base/content/test/sidebar/browser_sidebar_keys.js | Sidebar is closed - 
[task 2025-01-24T22:21:55.433Z] 22:21:55     INFO - Buffered messages finished
[task 2025-01-24T22:21:55.433Z] 22:21:55     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/sidebar/browser_sidebar_keys.js | Sidebar widget background should appear unchecked - 0.30000001192092896 == 0 - 
[task 2025-01-24T22:21:55.433Z] 22:21:55     INFO - Stack trace:
[task 2025-01-24T22:21:55.433Z] 22:21:55     INFO - chrome://mochitests/content/browser/browser/base/content/test/sidebar/browser_sidebar_keys.js:test_sidebar_in_customize_mode:107
[task 2025-01-24T22:21:55.433Z] 22:21:55     INFO - chrome://mochikit/content/browser-test.js:handleTask:1147
[task 2025-01-24T22:21:55.433Z] 22:21:55     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1219
[task 2025-01-24T22:21:55.433Z] 22:21:55     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1360
[task 2025-01-24T22:21:55.433Z] 22:21:55     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1136
[task 2025-01-24T22:21:55.433Z] 22:21:55     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2025-01-24T22:21:55.433Z] 22:21:55     INFO - Leaving test bound test_sidebar_in_customize_mode
[task 2025-01-24T22:21:55.735Z] 22:21:55     INFO - GECKO(1059) | MEMORY STAT | vsize 11469MB | residentFast 524MB | heapAllocated 266MB
[task 2025-01-24T22:21:55.736Z] 22:21:55     INFO - TEST-OK | browser/base/content/test/sidebar/browser_sidebar_keys.js | took 1950ms

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e8e6c3c9ad8
Disable expanded sidebar behaviour for horizontal tabs mode r=sidebar-reviewers,desktop-theme-reviewers,dao,jsudiaman,kcochrane

Comment 9

[agoloman]

Backed out for causing bc failures.

• Backout link
  ————————————————————————————————————
  Bc failures @browser_glean_sidebar.js.
• Push with failures
• Failure Log
  ————————————————————————————————————
  Bc failures @browser_toolbarButtonKeyPress.js
• Push with failures
• Failure Log

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ead9919b0da6
Disable expanded sidebar behaviour for horizontal tabs mode r=sidebar-reviewers,desktop-theme-reviewers,dao,jsudiaman,kcochrane

Comment 11

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89dba37a7a04
Backed out changeset ead9919b0da6 for causing failures at test_restore_sidebar.py. CLOSED TREE

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab0b1bfb4d28
Disable expanded sidebar behaviour for horizontal tabs mode r=sidebar-reviewers,desktop-theme-reviewers,dao,jsudiaman,kcochrane,sessionstore-reviewers

Comment 13

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/ab0b1bfb4d28

Comment 14

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Nightly build 136.0a1 (2025-01-30).