Closed Bug 1941961 Opened 26 days ago Closed 7 days ago

Move Nimbus initialization code into ExperimentAPI

Categories

(Firefox :: Nimbus Desktop Client, task, P1)

task

Tracking

()

RESOLVED FIXED
137 Branch
Tracking Status
firefox137 --- fixed

People

(Reporter: beth, Assigned: beth)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

The Nimbus initialization logic lives in Normandy.finishInit. We should move this into a top level method on ExperimentAPI because (a) Normandy is going away and (b) it will be cleaner to manage all Nimbus state from a single place. This will also pave the way for future cleanups in this space.

Blocks: 1941963
Attachment #9459797 - Attachment description: Bug 1941961 - Move Nimbus initialization logic into ExperimentAPI r?chumphreys → Bug 1941961 - Move Nimbus initialization logic into ExperimentAPI r?emcminn
Pushed by brennie@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e91e197a2a1d Move Nimbus initialization logic into ExperimentAPI r=emcminn
Flags: needinfo?(brennie)
Flags: needinfo?(brennie)
Pushed by brennie@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0881f0436233 Move Nimbus initialization logic into ExperimentAPI r=emcminn

Backed out for causing perma bc failures @ browser_experimentstore_load_single_feature.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/456607ce203363ae5faf5deaea8f3c3ad0916d70

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | toolkit/components/nimbus/test/browser/browser_experimentstore_load_single_feature.js | Uncaught exception in test bound test_load_from_disk_event

Buffered messages finished
[task 2025-01-24T17:34:21.428Z] 17:34:21     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/nimbus/test/browser/browser_experimentstore_load_single_feature.js | Uncaught exception in test bound test_load_from_disk_event - at chrome://mochitests/content/browser/toolkit/components/nimbus/test/browser/browser_experimentstore_load_single_feature.js:55 - TypeError: ExperimentManager is not a constructor
[task 2025-01-24T17:34:21.428Z] 17:34:21     INFO - Stack trace:
[task 2025-01-24T17:34:21.428Z] 17:34:21     INFO - test_load_from_disk_event@chrome://mochitests/content/browser/toolkit/components/nimbus/test/browser/browser_experimentstore_load_single_feature.js:55:19
[task 2025-01-24T17:34:21.428Z] 17:34:21     INFO - async*handleTask@chrome://mochikit/content/browser-test.js:1147:26
[task 2025-01-24T17:34:21.428Z] 17:34:21     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1219:18
[task 2025-01-24T17:34:21.428Z] 17:34:21     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1360:14
[task 2025-01-24T17:34:21.428Z] 17:34:21     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1136:14
[task 2025-01-24T17:34:21.428Z] 17:34:21     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13
[task 2025-01-24T17:34:21.428Z] 17:34:21     INFO - Leaving test bound test_load_from_disk_event
[task 2025-01-24T17:34:21.695Z] 17:34:21     INFO - GECKO(25063) | MEMORY STAT | vsize 11316MB | residentFast 423MB | heapAllocated 242MB
Flags: needinfo?(brennie)
Flags: needinfo?(brennie)
Pushed by brennie@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1640096187fa Move Nimbus initialization logic into ExperimentAPI r=emcminn

Backed out for causing xpcshell failures in test_defaultEngine.js.

Flags: needinfo?(brennie)
Depends on: 1944677
Pushed by brennie@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d68de267512f Move Nimbus initialization logic into ExperimentAPI r=emcminn

Backed out 2 changesets (Bug 1944677, Bug 1941961) for causing xpcshell failures on test_defaultEngine.

Push with failures

Failure log

Backout link

Flags: needinfo?(brennie)
Pushed by brennie@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ff5432cc7e7c Move Nimbus initialization logic into ExperimentAPI r=emcminn
Status: NEW → RESOLVED
Closed: 7 days ago
Resolution: --- → FIXED
Target Milestone: --- → 137 Branch
Blocks: 1946763
Blocks: 1946765
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: