1944677 - userPrefersReducedMotion is undefined in xpcshell tests

Status: RESOLVED FIXED

(Firefox :: Nimbus Desktop Client, defect, P1)

Description

[Beth Rennie [:beth] (she/her)]

The work from bug 1941961 was backed out because we triggered some logging in the targeting context recorder:

TEST-UNEXPECTED-FAIL | xpcshell.toml:toolkit/components/search/tests/xpcshell/test_defaultEngine.js | test_switch_with_invalid_overriddenBy - [test_switch_with_invalid_overriddenBy : 614] Unexpected console message received during test: TargetingContextRecorder: Could not get "userPrefersReducedMotion" - false == true

As it turns out, this property is undefined in xpcshell tests because xpcshell tests used a stubbed out version of nsIXULAppInfo that does not define the property.

Comment 1

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1944677 - Coerce userPrefersReducedMotion to false in targeting context recorder r?emcminn

This property can only be undefined if we are in an xpcshell tests
because it uses a stubbed nsIXULAppInfo.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4fbb13527586
Coerce userPrefersReducedMotion to false in targeting context recorder r=emcminn

Comment 3

[Cosmin Sabou [:CosminS]]

Backed out 2 changesets (Bug 1944677, Bug 1941961) for causing xpcshell failures on test_defaultEngine.

Push with failures

Failure log

Backout link

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ccc24e3e83b5
Coerce userPrefersReducedMotion to false in targeting context recorder r=emcminn

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/ccc24e3e83b5