1941989 - Split AdmWikipedia into two modules

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Drew Willcoxon :adw]

As part of bug 1941988, we'll need to send the quick-suggest ping only for AMP suggestions, not also Wikipedia suggestions like we currently do. This is a good opportunity to go ahead and split AdmWikipedia into two modules, one for AMP and one for Wikipedia, like we've talked about doing before.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1941989 - Split AdmWikipedia into two modules and send the quick-suggest ping only for AMP suggestions.

This makes two major changes:

Split AdmWikipedia into AmpSuggestions and OfflineWikipediaSuggestions. I
included "offline" in the name because Merino also serves Wikipedia suggestions,
but they're the so-called "dynamic Wikipedia" suggestions served from
Elasticsearch, and they have never been managed by a
BaseFeature/SuggestFeature in Firefox.

Send the quick-suggest ping only for AMP suggestions, in AmpSuggestions.
Stop sending it for offline Wikipedia suggestions. @bholley and I discussed this
on the [e-mail] list after I emailed it for the senstive data
review in D233752 [1]. We only use the ping for AMP suggestions, and Wikipedia
telemetry should follow the usual data opt-out. @nanj agreed the ping isn't
necessary for Wikipedia.

[1] https://groups.google.com/a/mozilla.com/g/data-review/c/BC2JKaXA7nA

Depends on D234440

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0311677cc3cc
Split AdmWikipedia into two modules and send the quick-suggest ping only for AMP suggestions. r=daisuke

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0311677cc3cc