Closed Bug 1941990 Opened 1 month ago Closed 1 month ago

Allow SuggestProvider to manage at most one Rust suggestion type

Categories

(Firefox :: Address Bar, task, P1)

task

Tracking

()

RESOLVED FIXED
136 Branch
Tracking Status
firefox136 --- fixed

People

(Reporter: adw, Assigned: adw)

References

(Blocks 1 open bug)

Details

(Whiteboard: [sng])

Attachments

(1 file)

After bug 1941989 is fixed, there won't be any remaining SuggestProvider subclasses that manage more than one Rust suggestion type, so we should update SuggestBackendRust and the SuggestProvider interface accordingly.

With D234449 fixed, we can change SuggestProvider.rustSuggestionTypes (plural)
to rustSuggestionType (singular). We can remove isRustSuggestionTypeEnabled
too because it's assumed that if the feature itself is enabled then its Rust
suggestions are too. I don't expect we'll ever need to break that assumption,
but if we do, we can just add back isRustSuggestionTypeEnabled at that time.

Depends on D234449

Pushed by dwillcoxon@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8518ea01151c Allow SuggestProvider to manage at most one Rust suggestion type. r=daisuke
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
Blocks: 1946894
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: