1942095 - Newtab startupcache race condition

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect, P2)

Description

[Scott [:thecount] Downe]

Seeing a couple race conditions with the startup cache.

The big one being:

1. If the events that flip isForStartupCache happen before startup cached page has rehydrated, the rehydrated page doesn't have the updated state from those events.

Other race condition I have found:
2. If sponsored topsites finishes before sponsored stories, or vice versa, and flips isForStartupCache, the other section displays a cached ad.

Comment 1

[Scott [:thecount] Downe]

Attachment: Bug 1942095 - Newtab fixing startupcache race conditions

Comment 2

[Mike Conley (:mconley) (:⚙️)]

It turns out that bundling as a built-in addon makes these kinds of races more likely to occur, so we should get this landed before bug 1949511 changes our default packaging to be as a built-in addon.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32108159b296
Newtab fixing startupcache race conditions. r=home-newtab-reviewers,mconley

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee89e21f7e66
Revert "Bug 1942095 - Newtab fixing startupcache race conditions. r=home-newtab-reviewers,mconley" for causing bc failures @ browser_overwrite_cache.js

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_overwrite_cache.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/ee89e21f7e667bc06ba73169a152dc3d11d1d24b

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/extensions/newtab/test/browser/abouthomecache/browser_overwrite_cache.js | leaked 2 window(s) until shutdown [url = about:home]

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4cb26c054a29
Newtab fixing startupcache race conditions r=home-newtab-reviewers,mconley

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/4cb26c054a29

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Mass moving from [hnt-trainhop] to [hnt-trainhop-project] for better JIRA book-keeping.