1942177 - remove nsIMsgFolder::closeDBIfFolderNotOpen()

Status: NEW

(MailNews Core :: Backend, task)

Description

[Ben Campbell]

After Bug 1941332, nsIMsgFolder::closeDBIfFolderNotOpen() doesn't do much and doesn't really do what the name says any more.

I recommend removing it entirely. It's trivial and only used in a few places:

https://searchfox.org/comm-central/search?path=&q=closeDBIfFolderNotOpen

and only one of those uses the "force" param. So they'd just be inlined as:

if (!(mFlags & (nsMsgFolderFlags::Trash | nsMsgFolderFlags::Inbox))) {
    SetMsgDatabase(nullptr);
}

(And, bigger-picture, I don't think folders should ever have to do this awful hoop-jumping hackery anyway! Bug 1795178 :-)