1941332 - Remove nsIMsgWindow.openFolder

Status: RESOLVED FIXED

(MailNews Core :: Backend, task)

Description

[Magnus Melin [:mkmelin]]

Remove nsIMsgWindow.openFolder. Paves the way for eventually dropping nsIMsgWindow altogether.

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: Bug 1941332 - Remove nsIMsgWindow.openFolder. r=BenC

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9ba85c3b7905
Remove nsIMsgWindow.openFolder. r=BenC

Comment 3

[Yury]

Some post-landing questions:

Why was imapFolder->UpdateFolderWithListener(nullptr, this); added here: https://hg.mozilla.org/comm-central/rev/9ba85c3b7905#l7.76 ?

https://searchfox.org/comm-central/rev/dccc40bbd446fc898f120e6da9986755617899dc/mail/modules/MailUtils.sys.mjs#774 was added in bug 1787609 calling closeDBIfFolderNotOpen(true); to force-close a folder if not open in a window during a search which potentially opens many folders.

What is implemented now force-closes the DB even if its folder is open in the window. Does findMsgIdInFolder() still work, or IOW, are there any consequences when that function force-closes the DB of the current folder?

Comment 4

[Magnus Melin [:mkmelin]]

My recall of the details is somewhat blurry, but IIRC it was needed as I had to re-wire the delete/detach attachment logic a bit to use normal urllistener logic and not swap around which listener it used. https://hg.mozilla.org/comm-central/rev/9ba85c3b7905#l19.211

findMsgIdInFolder() still works fine AFAICT. Certainly possible there could be some side-effects, but haven't seen any.