1942206 - Expose a quick light/dark toggle for the dark reader mode

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, enhancement, P1)

Description

[Alessandro Castellani [:aleca]]

Dark reader works fairly well but it's not immune to issues especially if some strangely or heavily formatted emails.
Let's offer a simple toggle to quickly turn it off for a single message to offer and easy fallback if something goes wrong.

Comment 1

[Alessandro Castellani [:aleca]]

Attachment: Bug 1942206 - Implement a quick dark reader toggle in the message header. r=#thunderbird-front-end-reviewers

Comment 2

[Alessandro Castellani [:aleca]]

Attachment: request.md

Comment 3

[Andrei Hajdukewycz [:sancus]]

Comment on attachment 9460618 [details]
request.md

Approved.

1. Is there Documentation?

• This collection is documented in the Glean Dictionary at https://dictionary.telemetry.mozilla.org/
• https://hg.mozilla.org/comm-central/mail/metrics.yaml

2. Is there a control mechanism that allows the user to turn this data collection off?

Yes: Standard telemetry preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Andrei Hajdukewycz (:sancus).

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2: Interaction data.

Is the data collection request for default-on or default-off?

default-on

Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No.

Is the data collection covered by the existing Thunderbird privacy notice? If unsure: escalate to legal if:

Yes.

Does the data collection use a third-party collection tool? If yes, escalate to legal.

No.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ef57e6efda40
Implement a quick dark reader toggle in the message header. r=freaktechnik,micahilbery,tobyp

Comment 5

[Alessandro Castellani [:aleca]]

[Why is this notable]: User's controllable "dark message mode" toggle. Also we set the "adapt message to dark mode" preference ON by default.
[Suggested wording]: Automatically adapt message to dark mode, and show a toggle in the message header to quickly disable/enable this feature. The toggle visibility is also controllable via a UI preference.

Comment 6

[Michel]

It works, just a few remarks:
I like how it dissapears on light themes, perhaps it can be made to be only visible when viewing full html email messages, when it actually changes something.
The color used should be Thunderbirds highlight color, not the system accent color. These are not always the same, depending on the used theme.
Just black & white or greys would be fine too.
The tooltip should be Toggle dark message mode, perhaps it can be made to alter between Enable.. and Disable...

Comment 7

[Alessandro Castellani [:aleca]]

(In reply to Michel from comment #6)

It works, just a few remarks:
I like how it dissapears on light themes, perhaps it can be made to be only visible when viewing full html email messages, when it actually changes something.
The color used should be Thunderbirds highlight color, not the system accent color. These are not always the same, depending on the used theme.
Just black & white or greys would be fine too.
The tooltip should be Toggle dark message mode, perhaps it can be made to alter between Enable.. and Disable...

Thanks for the feedback, could you open a new bug with request for enhancement and needinfo me?
We can evaluate all of these in the new bug and continue the conversation there.
Cheers