1942232 - [Wayland] Make WaylandBuffer release more robust

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

We need to make WaylandBuffer release more robust. It means:

• Take lock for WaylandBuffer internal changes
• Keep reference to WaylandSurface until WaylandBuffer is removed
• Keep attached/detached state as an additional flag
• Sync wl_buffer delete in case it's still attached to wl_surface

That ensures we don't release live buffers. Some of the work here is implemeneted at Bug 1743631.

Comment 2

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Attachment: Bug 1942232 [Wayland] Make WaylandBuffer release more robust r?emilio

Split WaylandBuffer attached state to two components:

• Attached to WaylandSurface is tracked by mAttachedToSurface direct reference to WaylandSurface.
• Attached to Wayland compositor (i.e. used by GPU) is tracked mIsAttachedToCompositor boolean flag.

Also change how wl_buffer is detached/deleted:

• BufferDetachedCallbackHandler() only clear mIsAttachedToCompositor flag while WaylandBuffer is still valid.
• BufferDeletedCallbackHandler() is used to clear wl_buffer when WaylandSurface is unmapped/deleted.

Such change ensures we keep references to WaylandSurface/WaylandBuffer pair even if WaylandBuffer is not recently used by GPU
and prevents early WaylandBuffer object delete.

Also add mutex tracking / debugging code to WaylandBuffer.

Comment 3

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Attachment: Bug 1942232 [Wayland] Make WaylandSurface more robust r?emilio

Allow to call AttachLocked() repeatedly for the same WaylandBuffer, it's used by widget code. Hold recently attached buffer by mAttachedBuffer
and all tracked buffers (attached but not released by compositor yet) at mTrackedBuffers.
It ensures we reference all buffers used by WaylandCompositor.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2606acece21a
[Wayland] Make WaylandBuffer release more robust r=emilio
https://hg.mozilla.org/integration/autoland/rev/cd369e4db2ee
[Wayland] Make WaylandSurface more robust r=emilio

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2606acece21a
https://hg.mozilla.org/mozilla-central/rev/cd369e4db2ee

Comment 6

[Cristian Tuns]

Backed out for causing Bug 1943732 and Bug 1943736

• Backout link

Comment 7

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Thanks, will rework it.

Comment 8

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Attachment: Bug 1942232 [Wayland] Detach and Release WaylandBuffer through WaylandSurface only r?emilio

WaylandBuffer detach/release can happen on various thread and races with WaylandSurface access to WaylandBuffer.
To ensure WaylandSurface/WaylandBuffer consistent state, manage WaylandBuffer via. WaylandSurface only.
Register all async callbacks to WaylandSurface and use WaylandSurfaceLock to access WaylandBuffer.

Comment 9

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Wayland try: https://treeherder.mozilla.org/jobs?repo=try&revision=2ca70afb9b5acf75b52e32fd76a4b4e8e39fb784

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5e50c8e4669
[Wayland] Detach and Release WaylandBuffer through WaylandSurface only r=emilio

Comment 11

[Atila Butkovits]

Backed out for causing failures at WaylandBuffer.cpp.

Backout link: https://hg.mozilla.org/integration/autoland/rev/00e77cc7ff4e9b3d3f86bef00fcbce137f152de0

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=f5e50c8e46694a3300cef68d6d86932f012c1e93&selectedTaskRun=GLRYsOF2Qxi4nV-_yJ9PJQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=493238699&repo=autoland&lineNumber=5790

Comment 12

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Updated, Thanks.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88c7eaa3296d
[Wayland] Detach and Release WaylandBuffer through WaylandSurface only r=emilio

Comment 14

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/88c7eaa3296d