1943732 - [KDE] Menus were missing multiple features including highlighting of items and icons

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P1)

Description

[Matt Fagnani]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:136.0) Gecko/20100101 Firefox/136.0

Steps to reproduce:

I started Firefox 136.0a1 20250124210220 on Wayland in Plasma 6.2.5 in a Fedora 41 KDE installation. I opened menus in the menu bar and moved the cursor over them. I clicked on various menu items in the menus. I opened dropdown menus on bugzilla.mozilla.org and moved the cursor over them. I opened the hamburger menu and moved the cursor over them. I opened context menus and moved the mouse over them.

Actual results:

Menus in the menu bar were had no highlighting of items under the cursor. The icons normally at the left and right of the menu items were sometimes missing. The menus were occasionally missing parts mainly at their bottom. Dropdown menus on bugzilla.mozilla.org didn't have highlighting of items under the cursor. Dropdown menus didn't show the scroll bar at their right sides and I couldn't scroll up and down normally on them. The hamburger menu had no highlighting of its items under the mouse. The context menus had no highlighting of their items under the mouse.

The problem didn't happen with 136.0a1 20250124093526. I bisected the problem to two patches for Bug 1942232
[Wayland] Make WaylandSurface more robust
[Wayland] Make WaylandBuffer release more robust

3:59.26 INFO: Narrowed integration regression window from [7f70d3a8, cd369e4d] (3 builds) to [3c707427, cd369e4d] (2 builds) (~1 steps left)
3:59.26 INFO: No more integration revisions, bisection finished.
3:59.27 INFO: Last good revision: 3c7074274bf7d666c762a0205d71c6e9bb46821c
3:59.27 INFO: First bad revision: cd369e4db2eec3a8cb0d72971326acba77e309c9
3:59.27 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3c7074274bf7d666c762a0205d71c6e9bb46821c&tochange=cd369e4db2eec3a8cb0d72971326acba77e309c9

Expected results:

The menus should've been shown normally.

Comment 1

[Matt Fagnani]

Scrolling in bookmarks menus from the menu bar also didn't work properly. The down scroll icon at the bottom of the bookmarks menu in the menu bar was missing. When I tried to scroll down on the bookmarks menu with the mouse wheel, the submenus of the items under the cursor were incorrect and showed menus for lower items in the bookmarks menu. This was as if the bookmarks menu had been scrolled down, but the menu wasn't updated to show that change. Some of the bookmarks submenus were missing their top parts.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:stransky, since you are the author of the regressor, bug 1942232, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

We should revert Bug 1942232 as it needs more investigation.

Comment 4

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

It's KDE only. Looks like KDE doesn't process damage regions correctly so so the page is not updated. Will look at it ASAP. No need to revert now, will decide on Monday.

Comment 5

[lilydjwg]

Wayfire user here. I can't see highlight of current menu item, and icons may be missing. I didn't check other symptoms before I downgraded.

Comment 6

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Okay, will look at it.

Comment 7

[Kevin Locke]

I'm seeing similar issues under sway/wlroots: Menu items under cursor aren't highlighted, can't open submenus from main menu, can't scroll bookmarks dropdown, color selection doesn't change when creating tab group. Same regression range: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3c7074274bf7d666c762a0205d71c6e9bb46821c&tochange=cd369e4db2eec3a8cb0d72971326acba77e309c9

Comment 8

[Emilio Cobos Álvarez (:emilio)]

I can repro too.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Fwiw not sure if this is a hint or what, bit this affects the main window too if I use LIBGL_ALWAYS_SOFTWARE=1, which is used by rr. So this makes debugging with rr quite hard on anything non-gnome...

Comment 10

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

I think Bug 1943732 is another incarnation of this one - I guess the damage region is wrong somehow.

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox136 (nightly). We have limited time to fix this, the soft freeze is in 3 days. However, the bug still isn't assigned and has low priority.

:gcp, could you please find an assignee and increase the priority for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 15

[Gian-Carlo Pascutto [:gcp]]

Emilio, Martin, with the soft freeze coming up the other bug will have to be backed out. This got a ton of dupes.

Comment 16

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

I'd like to look at it today and if I don't find it let's backout it tomorrow, is that okay for you?

Comment 17

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

The problem here is that we keep to use old wl_buffer after detach signal.

Comment 18

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Let's revert Bug 1942232. I have a patch for it but it needs more testing.

Comment 19

[Donal Meehan [:dmeehan]]

The regressor was backed out https://bugzilla.mozilla.org/show_bug.cgi?id=1942232#c6