Closed
Bug 1942255
Opened 2 months ago
Closed 2 months ago
Add ABI call fallback to CacheIRCompiler::emitGuardToInt32ModUint32
Categories
(Core :: JavaScript Engine: JIT, enhancement, P1)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
136 Branch
Tracking | Status | |
---|---|---|
firefox136 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Add an ABI call fallback to CacheIRCompiler::emitGuardToInt32ModUint32
to handle the case when branchTruncateDoubleMaybeModUint32
fails. This avoids emitting "SetProperty" ICs, see bug 1939427.
Assignee | ||
Comment 1•2 months ago
|
||
This ensures we don't repeatedly fail in CacheIRCompiler::emitGuardToInt32ModUint32
,
which would lead to using a generic "SetProperty" IC.
Pushed by andre.bargull@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a8874e1e97e4
Add ABI call fallback to CacheIRCompiler::emitGuardToInt32ModUint32. r=jandem
Updated•2 months ago
|
Severity: -- → S3
Priority: -- → P1
Updated•2 months ago
|
Severity: S3 → N/A
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
status-firefox136:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•