1942389 - "Sponsored stories" tickbox is visible and looks toggle-able when "Recommended stories" is turned off (but can't actually be toggled)

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[:Gijs (he/him)]

Attachment: Screenshot

On Firefox 128 this checkbox disappears if you turn off "recommended stories".

On current beta and nightly, it stays visible, and if you click it the active state makes the checkbox bigger (!?) but ultimately it does not toggle. It shouldn't look enabled if it's disabled, and perhaps shouldn't be visible at all if it can't be toggled unless the "parent" toggle is turned on.

Spotted on macOS, not sure if this happens on all platforms but I suspect so.

Comment 1

[:Gijs (he/him)]

Looks like this broke in bug 1917305. Hanna, I'm guessing this wasn't planned/designed? I suspect there's some activity-stream CSS that's overriding the right styles, or something.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1917305

Comment 3

[Hanna Jones [:hjones]]

Attachment: Bug 1942389 - fix the hiding/showing of nested fields in the ContentSection r=#home-newtab-reviewers

Comment 4

[Ryan VanderMeulen [:RyanVM]]

FYI, we're building the Fx135 RC on Monday, so this will need to land and get an uplift request ASAP if you wanted to avoid shipping this bug.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db84093cedcf
fix the hiding/showing of nested fields in the ContentSection r=home-newtab-reviewers,mconley

Comment 6

[Hanna Jones [:hjones]]

Comment on attachment 9460570 [details]
Bug 1942389 - fix the hiding/showing of nested fields in the ContentSection r=#home-newtab-reviewers

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: We'll introduce the issue described in Bug 1942389 - "Sponsored stories" tickbox is visible and looks toggle-able when "Recommended stories" is turned off (but can't actually be toggled) into release
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Open the Home/New Tab Page

2. click the "settings" icon button in the top right hand corner of the page to open the settings drawer
3. Toggle either "Shortcuts" or "Recommended Stories" off (these may be locale dependent). If the toggles are on/blue they should have indented form fields/inputs nested beneath them.
4. Verify that the nested/dependent checkboxs and other form fields below the toggle get hidden
5. Flip the toggle back to on
6. Verify that the nested/dependent fields are now shown

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The bug was essentially introduced via a typo - this is just restoring the behavior we had before.
• String changes made/needed: No
• Is Android affected?: No

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/db84093cedcf

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9460570 [details]
Bug 1942389 - fix the hiding/showing of nested fields in the ContentSection r=#home-newtab-reviewers

Approved for 135.0rc1.

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/c154e5776de2

Comment 10

[Mayank Bansal]

Looks to have regressed a sub-test of TART by 1%-3%. .
Please note that this sub-test is tagged to NOT create perf alert, and no action is required. This comment is only a FYI.